Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front: Mediainfo Popup #295

Merged
merged 18 commits into from
Jan 22, 2024
Merged

Front: Mediainfo Popup #295

merged 18 commits into from
Jan 22, 2024

Conversation

Arthi-chaud
Copy link
Collaborator

@Arthi-chaud Arthi-chaud commented Jan 21, 2024

Media Info Popup for Episodes and Movies. (closes #287)
Screenshot 2024-01-21 at 13 10 54

A few questions/problems:

  • Which Icon should we use for context menus? (Currently we use Info, but it is the same as Go To Show)
  • Whether it is from a context menu or a movie page's header, we always need to click the button twice for the popup to work

@Arthi-chaud Arthi-chaud added the front Change on the front-end side of the app label Jan 21, 2024
@Arthi-chaud Arthi-chaud self-assigned this Jan 21, 2024
@zoriya zoriya added this to the v4.2.0 milestone Jan 21, 2024
@zoriya
Copy link
Owner

zoriya commented Jan 21, 2024

What about this icon https://fonts.google.com/icons?selected=Material+Symbols+Outlined:movie_info:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=info ?

@zoriya
Copy link
Owner

zoriya commented Jan 21, 2024

For the double press needed, I don't understand why but it works with:

	const [isInfoOpen, setInfoOpen] = useState(false);
	return <>
			<Menu>
				<Menu.Item onSelect={() => setInfoOpen(true)} />
			</Menu>
			{isInfoOpen && type !== "show" && (
				<MediaInfoPopup mediaType={type} mediaSlug={slug} close={() => setInfoOpen(false)} />
			)}
	</>

@zoriya
Copy link
Owner

zoriya commented Jan 21, 2024

I think it could be nice to also add duration and file size to this popup. File size is currently not available, but I'll think about adding it to the endpoint. Duration is available in a field named length

@zoriya
Copy link
Owner

zoriya commented Jan 22, 2024

On android, the popup can overflow and the user is not able to scroll it. You probably need to wrap it with a scrollview.

Screenshot_20240122-170325.png

@zoriya zoriya marked this pull request as ready for review January 22, 2024 19:26
@zoriya zoriya enabled auto-merge (rebase) January 22, 2024 19:26
@zoriya zoriya merged commit 9c03bac into master Jan 22, 2024
10 checks passed
@zoriya zoriya deleted the front/mediainfo-popup branch January 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front Change on the front-end side of the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mediainfo popup
2 participants