-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front: Mediainfo Popup #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoriya
reviewed
Jan 21, 2024
zoriya
reviewed
Jan 21, 2024
zoriya
reviewed
Jan 21, 2024
zoriya
reviewed
Jan 21, 2024
For the double press needed, I don't understand why but it works with: const [isInfoOpen, setInfoOpen] = useState(false);
return <>
<Menu>
<Menu.Item onSelect={() => setInfoOpen(true)} />
</Menu>
{isInfoOpen && type !== "show" && (
<MediaInfoPopup mediaType={type} mediaSlug={slug} close={() => setInfoOpen(false)} />
)}
</> |
I think it could be nice to also add duration and file size to this popup. File size is currently not available, but I'll think about adding it to the endpoint. Duration is available in a field named length |
… add missing translations
Arthi-chaud
force-pushed
the
front/mediainfo-popup
branch
from
January 22, 2024 09:57
f1e9408
to
08de960
Compare
zoriya
reviewed
Jan 22, 2024
zoriya
force-pushed
the
front/mediainfo-popup
branch
from
January 22, 2024 17:21
565689a
to
9222566
Compare
zoriya
force-pushed
the
front/mediainfo-popup
branch
from
January 22, 2024 18:35
b3b778c
to
c105f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Info Popup for Episodes and Movies. (closes #287)
A few questions/problems:
Info
, but it is the same asGo To Show
)