Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front: Fix Media Metadata #582

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Front: Fix Media Metadata #582

merged 3 commits into from
Aug 4, 2024

Conversation

Arthi-chaud
Copy link
Collaborator

@Arthi-chaud Arthi-chaud commented Aug 4, 2024

The MediaSessionManager seems to be broken:

Screenshot 2024-08-04 at 19 46 57

This PR provides a fix (there was a mismatch between props of <Video/> and <MediaSessionManager/>)

Additionally, I took the liberty to rework the format of the data passed to <NativeVideo/> and <MediaSessionManager/>:

  • We pass the poster (of the movie or the parent show) instead of the thumbnail
  • The pass a subtitle, only for episodes, which will be the name of the show
    • Fun fact, NativeVideo actually accept such a prop, didn't know that. For web, it will be considered as the album name

Screenshots

Screenshot 2024-08-04 at 19 46 45 Screenshot 2024-08-04 at 19 47 32

@Arthi-chaud Arthi-chaud added enhancement New feature or request front Change on the front-end side of the app labels Aug 4, 2024
@Arthi-chaud Arthi-chaud requested a review from zoriya August 4, 2024 17:53
@Arthi-chaud Arthi-chaud self-assigned this Aug 4, 2024
@Arthi-chaud Arthi-chaud changed the title Fix the Media Metadata Front: Fix Media Metadata Aug 4, 2024
@zoriya zoriya enabled auto-merge (rebase) August 4, 2024 18:03
@zoriya
Copy link
Owner

zoriya commented Aug 4, 2024

Thanks for yet another great contribution!

@zoriya zoriya merged commit ddc3e8f into master Aug 4, 2024
11 checks passed
@zoriya zoriya deleted the front/fix-mediasessionmanager branch August 4, 2024 18:07
@zoriya zoriya added this to the v4.7.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front Change on the front-end side of the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants