Skip to content

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Jan 20, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@taban03 taban03 requested a review from balhar-jakub January 20, 2021 14:57
@taban03 taban03 added the do not merge Do not merge! label Jan 20, 2021
@taban03 taban03 removed the do not merge Do not merge! label Jan 21, 2021
taban03 and others added 3 commits January 21, 2021 13:29
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

7.5% 7.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@balhar-jakub balhar-jakub merged commit 70c2d71 into master Jan 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the rip/GH998/add_eviction_strategy branch January 21, 2021 13:20
CarsonCook pushed a commit that referenced this pull request Jan 26, 2021
* Add mechanism for reject eviction strategy

Signed-off-by: at670475 <andrea.tabone@broadcom.com>

* Add method to retrieve all the records unbound from service ID

Signed-off-by: at670475 <andrea.tabone@broadcom.com>

* Temporary change for testing

* Add mapping for maxsize in the vsamconfig

* Add config to retrieve logs

* Log error in proper way

* add debug log

* attempt

* Change allowed Records Num for testing

* put back the right allowed records value

* temporary change amount of record

* set amount of record back

* Remove temporary changes

* Fix rebasing

* Refactoring

* Add configuration for the general strategy

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>

* Remove temporary changes for debug purpose

* Fix endline

* Add space

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>

* Change line endings

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>

Co-authored-by: Jakub Balhar <jakub@balhar.net>
Co-authored-by: Jakub Balhar <jakub.balhar@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants