Skip to content

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented May 24, 2021

Signed-off-by: achmelo a.chmelo@gmail.com

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to #1429

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

achmelo added 3 commits May 24, 2021 18:15
Signed-off-by: achmelo <a.chmelo@gmail.com>
Signed-off-by: achmelo <a.chmelo@gmail.com>
Signed-off-by: achmelo <a.chmelo@gmail.com>
@sonarqubecloud
Copy link

@achmelo achmelo changed the title (WIP) websocket authentication support feat: websocket authentication support May 24, 2021
Copy link
Contributor

@jandadav jandadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gimme those approves!

@achmelo achmelo merged commit 112da99 into master May 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the rip/GH1429/ws_auth branch May 25, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants