-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yudai code #61
Add yudai code #61
Conversation
Conflicts arose between some yudai code and code from termoshtt's git-branches improvements, but the resolution is clean.
I don't know why I made a pull request. Instead I just pushed to master, since I can do that now, and this code is already in use by several people, so it's been reviewed by more than just me. |
Thank you for merging! 👍 |
Btw, this commit 45a411c changes the default behavior and that can bring up some confusion for most users. If it's not required by other commits, it might be better to revert this one. |
Actually, I saw that it changed the default behavior. It was actually in Thanks for your work. I only merged that first set of commits and not the Anyway, you should definitely make pull requests with any future work you On Mon, Jun 22, 2015 at 12:59 PM, Iwasaki Yudai notifications@github.com
|
Got it. As for the inplace search, I feel like my code is a little bit hacky as I was not so familiar with zsh/zaw and wrote it in a "anyway, it looks it's working" way. So if your PR works fine for the same purpose, it would be great to drop my commits and adopt your smarter way 👍 Here is a video for reference: |
To clarify -- I added code to allow initial filter contents, primarily for the zaw-history source. I haven't done anything related to in place searching. |
Thanks. I realized that your PR is for the initial filter pattern and updated/rebased my code with it. My inplace search is just use the current shell line as the filter prompt. I'm not sure it makes sense for others. So let me know if you are interested in it. I'll create a PR then. |
This merges in a bunch of code from the fork of @yudai. Several contributors to zaw are using this code in their forks, and at least one pull request submitted to the main zsh-users repo requires some of these commits. This commit represents a merger of Yudai's code up to his latest 5 commits, which add features that aren't all working for me.