-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder sidebar org list by dragging #1059
base: main
Are you sure you want to change the base?
Conversation
@akashnimare is it possible for you test this out ? |
681cdaa
to
5544153
Compare
The code logic looks fine to me and the feature is working. The PR can be reviewed and ready for merging if approved. cc @andersk @timabbott . |
Awesome, thanks for rebasing @abhigyank! @andersk do you have time to review this? I think it's one of the top few features users want in the desktop app. |
We have far too many indices flying around to be confident that it would be correct to start mutating them:
Before I’ll accept any PR that allows organizations to be reordered, I want as many of these indices as possible to be replaced by stable identifiers that do not change under reordering. (A good example of a stable identifier is the reference to the |
Heads up @abhigyank, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Is this merged? i would like to take on the issue @akashnimare @abhigyank |
Rebase and update PR #617 to master.
Feature works as expected, tested upto 5 organizations.
I haven't gone through the code and logic yet, and would soon do so, but I would encourage you to test the feature as is now and report in usability issues and mishappenings.