Show sidebar on navigating to Settings page #1084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andersk could you please review this? |
timabbott
reviewed
Mar 17, 2021
tarun8718
force-pushed
the
UI
branch
3 times, most recently
from
16bb7a4
to
468676b
Compare
Ayushsunny
approved these changes
Mar 26, 2021
Fixes zulip#1077 Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
|
Hey @tarun8718 Thanks for this PR. One question I have in mind is why are we adding this piece of code for accounts with only one organization, where if you have multiple, you'll probably still face the same issue? |
|
@tarun8718 Let me know if you need a hand or if we should continue the work as you've already done the most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tarun8718 tarunkumar8718@gmail.com
What's this PR do?
Shows Sidebar(if disabled) on navigating to the settings page(for users with single-organizations).
Fixes: #1077
You have tested this PR on: