Issue fix for #78 #118
Merged
Issue fix for #78 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lpenka It'll be great if you can create a new branch and make change for pull request. |
|
@sinwar I will surely take care of these from next time & i have run "npm test run" before PR , I don't think any further issues are left with code |
|
@Lplenka sorry for the delay. This looks fine. Thanks for working on this 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operating Sysytem-Linux Mint
Zulip Desktop Version :1.4.15
Issue : #78
There was no support for localhost zulip servers like this server
I Have fixed this problem
Switching between local and online servers also working fine
Any further suggestions in this issue are welcome