Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize "channel" as operator in narrow links #5860

Closed
chrisbobbe opened this issue Apr 23, 2024 · 0 comments · Fixed by #5862
Closed

Recognize "channel" as operator in narrow links #5860

chrisbobbe opened this issue Apr 23, 2024 · 0 comments · Fixed by #5862
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Apr 23, 2024 •
edited
Loading

In zulip/zulip#28468, we plan to rename "stream" to "channel" in the Zulip UI.

We should start to recognize narrow links with a "channel" operator, while continuing to recognize the "stream" operator (because links with the old operator will be present in existing messages). So, for example, the app should parse both of these URLs:

https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename
https://chat.zulip.org/#narrow/channel/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename

Discussion: https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1784294

Related issues:
@chrisbobbe chrisbobbe added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Apr 23, 2024
@chrisbobbe chrisbobbe changed the title Recognize "channel" as operand in narrow links Recognize "channel" as operator in narrow links Apr 23, 2024
This was referenced Apr 23, 2024
Open
Closed
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 24, 2024
@chrisbobbe
internalLinks [nfc]: Inline internal_url.by_stream{,_topic}_url
c5b7a78 
This refactor will help with zulip#5861, but Tim has reminded me that
we're not ready to address zulip#5861 until a release addressing zulip#5860
(as we did in the previous commit) has been out for a while:
  https://chat.zulip.org/#narrow/stream/378-api-design/topic/URLs.20for.20stream.20to.20channel.20rename/near/1786615
@chrisbobbe chrisbobbe mentioned this issue Apr 24, 2024
Merged
This was referenced Apr 24, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internalLinks: Recognize "channel" as operator in narrow links chrisbobbe/zulip-mobile
1 participant
@chrisbobbe