Show time mentions (with source text) in MsgInfoView #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an instance attribute, time_mentions, to the class MessageBox to log time mentions (with their source text) and eventually show them in MsgInfoView. Tests amended.
|
@preetmishra Thanks for the quick follow-up 👍 This looks fine - we could have waited for this in the previous PR, but this is a straightforward clean extension 🎉 It's quite useful to see what syntax works and doesn't in the time mentions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an instance attribute,
time_mentions, to the classMessageBoxto log time mentions (with their source text) and eventually show them inMsgInfoView.