Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_profile_fields: Display data of default external account type in edit form modal. #22942

Merged

Conversation

yogesh-sirsat
Copy link
Collaborator

@yogesh-sirsat yogesh-sirsat commented Sep 13, 2022

Remove redundant Val(" ") from an edit form modal of the custom
external account type field.

Display values of the "name" and "hint" field in a non-editable way while
editing default external account type profile fields.

Fixes: CZO

Screenshots and screen captures:
edit_form

Self-review checklist

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Display values of "name" and "hint" field in non-editable way while
editing default external account type profile fields.
@timabbott timabbott merged commit ce14df0 into zulip:main Sep 13, 2022
@timabbott
Copy link
Member

Merged, thanks @yogesh-sirsat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants