Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outgoing webhooks: Warn user that PMs are not supported in Slack-format webhook. #9814

Closed
wants to merge 2 commits into from
Closed

outgoing webhooks: Warn user that PMs are not supported in Slack-format webhook. #9814

wants to merge 2 commits into from

Commits on Aug 3, 2018

  1. tests: Rename 'event' to 'stream_message_event' for clarity.

    @rheaparekh
    rheaparekh committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    3547996 View commit details
    Browse the repository at this point in the history

  2. outgoing webhooks: Warn user that PMs are not supported in Slack-form… 

    …at webhook.

Private messages are not supported in Slack-format webhook.
Instead of raising a NotImplementedError, we warn the user
that PM service is not supported by sending a message to the
user.

Added tests for the same.

Fixes zulip#9239
    @rheaparekh
    rheaparekh committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    a280ca3 View commit details
    Browse the repository at this point in the history