Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PSR-3 logger support. #10

Merged
merged 6 commits into from
Jan 22, 2015
Merged

Added PSR-3 logger support. #10

merged 6 commits into from
Jan 22, 2015

Conversation

young-steveo
Copy link
Contributor

This PR adds support for injecting a PSR-3 logger into the configuration object, and sprinkles a few debug logs into the library.

$config = new \Zumba\Swivel\Config($map, $index);
$config->setLogger($logger);

@jrbasso
Copy link
Member

jrbasso commented Jan 22, 2015

@young-steveo Looks good, but can you rebase?

Since this class is created by the Manager (not the user), this simplifies the builder api a bit.
Removed the logger from the behavior to make it easier for users to create behaviors.
jrbasso added a commit that referenced this pull request Jan 22, 2015
Added PSR-3 logger support.
@jrbasso jrbasso merged commit 438146d into master Jan 22, 2015
@jrbasso jrbasso deleted the logging branch January 22, 2015 05:39
@young-steveo young-steveo mentioned this pull request Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants