#23 Add support for using a behavior with protected or private methods #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $strategy = function() use ($strategy) { | ||
| return $strategy; | ||
| }; | ||
| if (is_array($strategy) && count($strategy) === 2 && is_object($strategy[0]) && is_string($strategy[1])) { |
There was a problem hiding this comment.
@jonyo This is a little subjective, I could be passing and event object and something else. Also it doesn't support static calls, so why don't simply use is_callable()? See http://viper-7.com/ZlreM2
There was a problem hiding this comment.
@jonyo Ok, talking with @young-steveo we saw that is_callable is not applicable for this since doesn't check the protected/private, but the method_exists does. So this is probably the best option for this case.
jonyo
force-pushed
the
allow-protected-method-behaviors
branch
from
c4bc4aa
to
95d3e83
Compare
|
@jrbasso Good point, changes in. |
young-steveo
added a commit
that referenced
this pull request
Oct 8, 2015
#23 Add support for using a behavior with protected or private methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #23