Split public api #25
Merged
Split public api #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oke` to conform to the new builder policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains breaking changes that will lead to Swivel v2.0.0 after it is merged.
This PR simplifies the ambiguity surrounding
Builder::addBehaviorandManager::invokewhen automatically wrapping non-callables.Breaking Changes
Builder::addBehavior,Builder::defaultBehavior, andManager::invokeno longer accept non-callable$strategyparameter. These methods will throw a\LogicExceptionwhen a non-callable is passed.New API
Three new methods have been introduced to handle the functionality that was removed in the breaking changes:
Builder::addValueBuilder::defaultValueManager::returnValueThese methods are used to configure _Swivel_ to return a value that is not expected to be callable. In the case of passing a callable to these methods, the unexecuted callable will be returned.