php7.1: fix non-numeric value encountered warning #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some swivels can return empty string, and we can't perform bitwise & on
non-numeric values on 7.1 without getting a warning.
php 7.1 (adding cast eliminates the warning):
```
$ php --version
PHP 7.1.8-2+ubuntu16.04.1+deb.sury.org+4 (cli) (built: Aug 4 2017 13:04:12) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.1.8-2+ubuntu16.04.1+deb.sury.org+4, Copyright (c) 1999-2017, by Zend Technologies
$ php -r 'var_dump("" & 0);'
PHP Warning: A non-numeric value encountered in Command line code on line 1
int(0)
$ php -r 'var_dump((int)"" & 0);'
int(0)
```
php 5.6 (doesn't require the cast):
```
$ php --version
PHP 5.6.31-4+ubuntu16.04.1+deb.sury.org+4 (cli)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
$ php -r 'var_dump("" & 0);'
int(0)
$ php -r 'var_dump((int)"" & 0);'
int(0)
```
Signed-off-by: Rene Fragoso <ctrlrsf@gmail.com>
jrbasso
approved these changes
Aug 29, 2017
|
Travis failures are related with travis deprecating the HHVM. I will fix that in a separated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some swivels can return an empty string, and we can't perform bitwise & on
non-numeric values on 7.1 without getting a warning.
php 7.1 (adding cast eliminates the warning):
php 5.6 (doesn't require the cast):
Signed-off-by: Rene Fragoso ctrlrsf@gmail.com