Skip to content

feat: Add Winget package option #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2023
Merged

feat: Add Winget package option #137

merged 2 commits into from
Apr 5, 2023

Conversation

SinnoSong
Copy link
Contributor

Add Winget package option: use build.ps1 upload gptcommit.exe to Winget.
Use this command:

build.ps1 -Token <GitHubPersonalAccessToken> -Version <PublishVersion>

Or use Github action like :https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/.github/workflows/winget.yml

InstallerType: zip
Installers:
- Architecture: x64
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid hard-coding the version numbers here. Can we use the <VERSION> pattern here and below?

Suggested change
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v<VERSION>gptcommit-x86_64-pc-windows-msvc.zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be replaced.

- RelativeFilePath: .\gptcommit.exe
PortableCommandAlias: gptcommit
- Architecture: x86
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here


# Create PR
# wingetcreate submit --token <GitHubPersonalAccessToken> <PathToManifest>
wingetcreate submit --token $Token $Version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What permissions does the Github token need here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Github token is use for creating a PR in https://github.com/microsoft/winget-pkgs

@SinnoSong
Copy link
Contributor Author

@zurawiki I replaced hard-coding version

@zurawiki
Copy link
Owner

zurawiki commented Apr 4, 2023

The rest of the PR looks ok. How are we running this github action then? Should I copy workflow/winget.yml into this repo?

@SinnoSong
Copy link
Contributor Author

SinnoSong commented Apr 5, 2023

@zurawiki Yes, you need copy workflow/winget.yml into this repo. I don't know much about GitHub Action, and these are my suggestions:

@zurawiki zurawiki merged commit d35db86 into zurawiki:main Apr 5, 2023
@slacksystem
Copy link

Sorry if this is obvious but I did winget search gptcommit and got zero results. Am I missing something? I thought the latest release said it was implemented but I may be going about this wrong

@SinnoSong
Copy link
Contributor Author

@slacksystem There is no one PR be merged: https://github.com/microsoft/winget-pkgs/pulls?q=gptcommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you offer another way to install gptcommit for Windows? Like, Winget
3 participants