-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Add Winget package option #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
InstallerType: zip | ||
Installers: | ||
- Architecture: x64 | ||
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid hard-coding the version numbers here. Can we use the <VERSION>
pattern here and below?
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip | |
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v<VERSION>gptcommit-x86_64-pc-windows-msvc.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be replaced.
- RelativeFilePath: .\gptcommit.exe | ||
PortableCommandAlias: gptcommit | ||
- Architecture: x86 | ||
InstallerUrl: https://github.com/zurawiki/gptcommit/releases/download/v0.5.6/gptcommit-x86_64-pc-windows-msvc.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
|
||
# Create PR | ||
# wingetcreate submit --token <GitHubPersonalAccessToken> <PathToManifest> | ||
wingetcreate submit --token $Token $Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What permissions does the Github token need here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Github token is use for creating a PR in https://github.com/microsoft/winget-pkgs
@zurawiki I replaced hard-coding version |
The rest of the PR looks ok. How are we running this github action then? Should I copy workflow/winget.yml into this repo? |
@zurawiki Yes, you need copy workflow/winget.yml into this repo. I don't know much about GitHub Action, and these are my suggestions:
|
Sorry if this is obvious but I did |
@slacksystem There is no one PR be merged: https://github.com/microsoft/winget-pkgs/pulls?q=gptcommit |
Add Winget package option: use
build.ps1
uploadgptcommit.exe
to Winget.Use this command:
Or use Github action like :https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/.github/workflows/winget.yml