-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more libraries available #1917
Make more libraries available #1917
Conversation
What's the use-case for making it possible for plugins to make arbitrary http requests and unzip files? |
WakaTime is a plugin where eventually at the first time you install it in your machine must download a client. You can check what's about by going here www.wakatime.com and lookgin at my repo https://github.com/wakatime/micro-wakatime |
I realized you approved micro-editor/plugin-channel#57 but this PR haven't been approved yet and wakatime plugin might break if users install it. |
Hmm, would you like me to unlist it until this is resolved? You can also just require a higher version (which will be necessary anyway because these changes won't be backported to 2.0.8). I suppose I'm a little concerned about the security implications of allowing plugins to make http requests, but plugins can already run arbitrary shell commands so maybe it's not hugely different from that. Would it be reasonable to ask users to manually install the cli? An alternative approach could also be to run a shell script that is bundled with the plugin to perform the installation. Also instead of |
Allowing HTTP requests will also make it possible to create a plugin for Code::Stats. |
Actually all other IDEs allow the plugins to be autonomous enough and we don't require the users to install it manually unles they want to do it. Of course that's the normal flow for WakaTime. I don't see any concerns on allowing plugins to make http requests since they can fetch/send data from Apis. |
@zyedidia any update here? |
I started implementing a new plugin for this awesome project however I realized there's a lack of imported functions. So this PR makes few more libaries available when developing a plugin.
Also I added
Unzip
function toutil.go
. Since it's my very initial contribution please let me know if I missed something.Here is the PR for the plugin channel and here is the repo for the plugin.