Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline DQM for BTagMu and PFJet paths #19119

Merged
merged 53 commits into from Jul 7, 2017
Merged

Offline DQM for BTagMu and PFJet paths #19119

merged 53 commits into from Jul 7, 2017

Conversation

defranchis
Copy link
Contributor

Both for AK4 and AK8. This PR is based on PR#18981 (TopMonitor)

defranchis and others added 28 commits May 27, 2017 10:36
@defranchis
Offline DQM for Top HLT
b8c78ae
@defranchis
adding electron isolation for ele+jets
552890e
@defranchis
adding variable binning + multiplicity histograms
8173416
@defranchis
Merge pull request #5 from defranchis/DQM-try-to-cherrypick
01b00c3 
adding variable binning + multiplicity histograms
@defranchis
adding 2D histograms and efficiencies
b68cbb0
@defranchis
renaming directories
26414c6
@defranchis
updating from EDAnalyzer to DQMEDHarvester
5303a4a
@defranchis
adding further 2D distributions for di-lepton channel
7ae70ef
@defranchis
configuring variable binning
3003514
@defranchis
bug fix
f35341a
@defranchis
updating selection for ele+jets
6286bc3
@defranchis
updating pt binnings
5fbdb04
@mohsinwaseem
Updated Leptonic Paths
7735713
@mohsinwaseem
Reverted changes in HLTriggerOffline
bb8267c
@defranchis
Merge pull request #9 from mohsinwaseem/Test
dd87c03 
Updated Leptonic Paths
@marinakolosova @defranchis
merging code for fully-hadronic
cf5a011
@defranchis
adding default CSV working point
5611aef
@defranchis
Merge pull request #10 from defranchis/merge-from-fully-hadronic
1b97155 
Merge from fully hadronic
@sroychow
update top hlt dqm code to include PV cuts to be used by higgs montoring
61e8d65
@defranchis
adding string selection for b-jets
79cfa0e
@defranchis
removing single top and updating output directories
5f380f1
@defranchis
optimization and bug fix
0ae26fa
@defranchis
Merge pull request #12 from defranchis/merge-from-fully-hadronic
29ea8cc 
Merge from fully hadronic
@sroychow
Merge branch 'TopDQMOfflineHLT' into updateTotopdqm
40849d4
@sroychow
resolving conflicts with previous updates from bjet
c817647
@marinakolosova
Added Reference Monitoring
c7e5018
@defranchis
Merged refs/pull/18981/head from repository cms-sw
3b6908a
@defranchis
adding BTagMu and PFJet monitorning for AK4 and AK8
b8f531d
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 6, 2017
@smuzaffar smuzaffar added this to the CMSSW_9_3_X milestone Jun 27, 2017
@davidlange6
Copy link
Contributor

maybe @dmitrijus or other dqm person does.

@defranchis defranchis mentioned this pull request Jun 29, 2017
Closed
@mtosi
Copy link
Contributor

mtosi commented Jun 29, 2017

I'm confused :(
is this still valid ?

@defranchis
Copy link
Contributor Author

@mtosi yes, this is ready to be merged (after I provide the info about the number of bins added). The other one contains some updates. I guess it will be merged after

@fwyzard
Copy link
Contributor

fwyzard commented Jul 2, 2017

@defranchis this PR has automatically been moved to CMSSW 9.3.x .
Can you make a new PR for CMSSW 9.2.x ?
I think at the moment you can use the same branch.

@defranchis
Copy link
Contributor Author

@fwyzard here it is #19505

@jmduarte jmduarte mentioned this pull request Jul 2, 2017
Closed
@fwyzard fwyzard mentioned this pull request Jul 3, 2017
Closed
@gomber
Copy link
Contributor

gomber commented Jul 4, 2017

@defranchis can you provide nbins inforamtion, so that this PR can be merged? I guess thats the only action item left here. There are other PR in exotica also which relies on this one, so it would be helpful if this gets merged!

@defranchis
Copy link
Contributor Author

@gomber is there a smart way to get this information? Or do I have to create my own script?

@gomber
Copy link
Contributor

gomber commented Jul 4, 2017

@defranchis Unfortunately I didn't find any script or automatic way to do this. And that's what I was waiting for last one week atleast for my other PR. So at the end in order to just get this done, I spend 5 minutes with my code looking at the number of bins I am using. Just counted them!

@lathomas
Copy link
Contributor

lathomas commented Jul 5, 2017

Hi, I'm not sure this is the right place to ask but would it be possible to also monitor
HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_Mass3p8 in this DQM?
(since this code is already monitorng HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_Mass8 it should be ~trivial?)

Thanks.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 6, 2017

Hi @lathomas ,
given how long it takes for PRs to be reviewed and integrated, please open a new one rather than modify this one, that then will have to be signed all over again.

Ciao,
.Andrea

@fwyzard
Copy link
Contributor

fwyzard commented Jul 6, 2017

@davidlange6 what is holding up this PR from being integrated ?
It has been signed by DQM over two weeks ago.

@davidlange6
Copy link
Contributor

davidlange6 commented Jul 6, 2017 via email

@defranchis
Copy link
Contributor Author

@davidlange6 this PR adds 466424 bins

@lathomas lathomas mentioned this pull request Jul 6, 2017
Closed
davidlange6
davidlange6 reviewed Jul 7, 2017
View reviewed changes
DQMOffline/Trigger/plugins/TopMonitor.h
double xmax;
};

struct METME {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @defranchis - looks like I missed three things initially - please take care of these in a followup PR (and as part of the back port)

  1. move the definitions of MEbinning, METME and PVcut into the TopMonitor class itself
  2. initialize numerator and denominator to nullptr here (then you can remove a bunch of initializations later
  3. having something called METME in a TopMonitor class makes no sense. Please rename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks, I will make a new PR then

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e2d1d2 into cms-sw:master Jul 7, 2017
This was referenced Jul 7, 2017
Closed
Closed
@gomber gomber mentioned this pull request Jul 13, 2017
Closed
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 28, 2017
@fwyzard
backport HLT DQM for menu v2.1 to CMSSW 9.2.x
71bfa51 
This PR includes a backport of the following PRs:
  - cms-sw#18172
  - cms-sw#18950
  - cms-sw#18959
  - cms-sw#18968
  - cms-sw#18971
  - cms-sw#19023
  - cms-sw#19046
  - cms-sw#19078
  - cms-sw#19119
  - cms-sw#19178
  - cms-sw#19290
  - cms-sw#19293
  - cms-sw#19294
  - cms-sw#19490
  - cms-sw#19499
  - cms-sw#19577
  - cms-sw#19585
  - cms-sw#19596
  - cms-sw#19599
  - cms-sw#19627
  - cms-sw#19689
  - cms-sw#19694
  - cms-sw#19703
  - cms-sw#19781
  - cms-sw#19794

plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline.

It synchronises with CMSSW_9_3_X
  - DQMServices/ClientConfig
  - DQMOffline/Configuration
  - DQMOffline/Trigger
  - HLTriggerOffline/Btag
  - HLTriggerOffline/Higgs
  - HLTriggerOffline/SUSYBSM
  - HLTriggerOffline/Tau
  - HLTriggerOffline/Top
@fwyzard fwyzard mentioned this pull request Jul 28, 2017
Closed
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Sep 3, 2017
@fwyzard
backport HLT DQM for menu v2.1 to CMSSW 9.2.x
20188a1 
This PR includes a backport of the following PRs:
  - cms-sw#18172
  - cms-sw#18950
  - cms-sw#18959
  - cms-sw#18968
  - cms-sw#18971
  - cms-sw#19023
  - cms-sw#19046
  - cms-sw#19078
  - cms-sw#19119
  - cms-sw#19178
  - cms-sw#19290
  - cms-sw#19293
  - cms-sw#19294
  - cms-sw#19490
  - cms-sw#19499
  - cms-sw#19577
  - cms-sw#19585
  - cms-sw#19596
  - cms-sw#19599
  - cms-sw#19627
  - cms-sw#19689
  - cms-sw#19694
  - cms-sw#19703
  - cms-sw#19781
  - cms-sw#19794

plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline.

It synchronises with CMSSW_9_3_X
  - DQMServices/ClientConfig
  - DQMOffline/Configuration
  - DQMOffline/Trigger
  - HLTriggerOffline/Btag
  - HLTriggerOffline/Higgs
  - HLTriggerOffline/SUSYBSM
  - HLTriggerOffline/Tau
  - HLTriggerOffline/Top
mtosi pushed a commit to mtosi/cmssw that referenced this pull request Oct 17, 2017
@fwyzard @mtosi
backport HLT DQM for menu v2.1 to CMSSW 9.2.x
2befd4c 
This PR includes a backport of the following PRs:
  - cms-sw#18172
  - cms-sw#18950
  - cms-sw#18959
  - cms-sw#18968
  - cms-sw#18971
  - cms-sw#19023
  - cms-sw#19046
  - cms-sw#19078
  - cms-sw#19119
  - cms-sw#19178
  - cms-sw#19290
  - cms-sw#19293
  - cms-sw#19294
  - cms-sw#19490
  - cms-sw#19499
  - cms-sw#19577
  - cms-sw#19585
  - cms-sw#19596
  - cms-sw#19599
  - cms-sw#19627
  - cms-sw#19689
  - cms-sw#19694
  - cms-sw#19703
  - cms-sw#19781
  - cms-sw#19794

plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline.

It synchronises with CMSSW_9_3_X
  - DQMServices/ClientConfig
  - DQMOffline/Configuration
  - DQMOffline/Trigger
  - HLTriggerOffline/Btag
  - HLTriggerOffline/Higgs
  - HLTriggerOffline/SUSYBSM
  - HLTriggerOffline/Tau
  - HLTriggerOffline/Top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

@mtosi mtosi mtosi left review comments

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet