Simplify optimization tab #1514

nguyentvan7 · 2024-02-19T21:11:07Z

Describe your changes

Split Artifact conditional config into its own modal, as it is more of a prerequisite to optimization, and shouldn't be part of the optimization filters
Hide all optimization filters behind a modal to reduce visual stress
Change layout of optimization selector/optimize button to be more obvious
Hide graph information behind an accordion to reduce confusion
Change artifact set cards to show highest rarity for the background color
Change allowlist default state to be "custom list", so we are as permissive as possible for first optimization

Issue or discord link

Resolve Reduce visual clutter in the Optimization Tab #1455

Testing/validation

New optimize tab layout, featuring art set conditional modal button, artifact filter modal button, new opt selector/start layout and graph behind an accordion

Graph accordion expanded without a graph

Graph accordion expanded with a graph

Artifactfilter modal

Artifact set conditional modal

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

I have commented my code in hard-to understand areas.
I have made corresponding changes to README or wiki.
For front-end changes, I have updated the corresponding English translations.
I have run yarn run mini-ci locally to validate format and lint.
If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions · 2024-02-19T21:14:27Z

[sr-frontend] [Mon Feb 19 21:14:26 UTC 2024] - Building version 0df7722

[frontend] [Mon Feb 19 21:14:28 UTC 2024] - Building version 0df7722

[sr-frontend] [Mon Feb 19 21:14:29 UTC 2024] - Building version 3f85f3b

[sr-frontend] [Mon Feb 19 21:15:50 UTC 2024] - Deployed 0df7722 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:17:00 UTC 2024] - Deployed 3f85f3b to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:21:41 UTC 2024] - Building version 0013756

[sr-frontend] [Mon Feb 19 21:21:46 UTC 2024] - Building version 0013756

[sr-frontend] [Mon Feb 19 21:23:11 UTC 2024] - Deployed 0013756 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:24:12 UTC 2024] - Deployed 0013756 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:31:53 UTC 2024] - Building version 0a77a5d

[sr-frontend] [Mon Feb 19 21:31:54 UTC 2024] - Building version 0a77a5d

[sr-frontend] [Mon Feb 19 21:33:30 UTC 2024] - Deployed 0a77a5d to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 21:34:32 UTC 2024] - Deployed 0a77a5d to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon Feb 19 22:19:20 UTC 2024] - Building version c75fe49

[frontend] [Mon Feb 19 22:19:23 UTC 2024] - Building version c75fe49

[sr-frontend] [Mon Feb 19 22:20:55 UTC 2024] - Deployed c75fe49 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Feb 19 22:22:00 UTC 2024] - Deployed c75fe49 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Mar 5 19:38:22 UTC 2024] - Deployed 99cd7c1 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Mar 5 19:46:20 UTC 2024] - Deployed d1f2776 to https://genshin-optimizer-prs.github.io/pr/1514/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:47:14 UTC 2024] - Deployed d1f2776 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:49:05 UTC 2024] - Deployed 4683209 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 19:55:36 UTC 2024] - Deployed 9cf23d1 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 20:32:28 UTC 2024] - Deployed 92139e1 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 20:53:12 UTC 2024] - Deployed a90b0d4 to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 5 21:06:29 UTC 2024] - Deployed d9c94fc to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Mar 6 06:08:16 UTC 2024] - Deployed 482e80e to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Mar 8 17:29:33 UTC 2024] - Deployed fdf0acb to https://genshin-optimizer-prs.github.io/pr/1514/frontend (Takes 3-5 minutes after this completes to be available)

frzyc

Some minor comments

libs/gi/localization/assets/locales/en/page_character.json

libs/gi/db/src/Database/DataManagers/OptConfigDataManager.ts

libs/gi/localization/assets/locales/en/page_character_optimize.json

apps/frontend/src/app/PageTeam/CharacterDisplay/Tabs/TabOptimize/index.tsx

frzyc · 2024-03-05T23:29:26Z

Some additional comments to this new modal:

Move the title and [X Selected] to the modal title ( as well as moving some extra elements there)
convert the information at the top to an info Alert
minimize padding on the conditional selectors. (can we try removing all padding? might be confusing some conditional with multi-select conditional

frzyc · 2024-03-05T23:30:54Z

Since this modal is primarily dealing with filtering artifacts, we should rename the title to "Artifact Filters", and show the total artifacts filtered

frzyc · 2024-03-06T03:34:06Z

Also missing this button introduced in #1602

nguyentvan7 · 2024-03-06T17:11:59Z

Refine layout for forced 2 column setup (optimize buttons should be on the bottom right?)
Fix height of optimize buttons in forced 2 column setup
Experiment with a permanent 2 column setup with the optimize buttons in the bottom right
Remove default change to allowlist setting

* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>

This reverts commit ca73f9f.

* Condense characters page (#1621) * fix null checks (#1624) * Cache more actions (#1622) * cache more * Add comment * Speed up builds (#1626) * drop unnecessary deps * remove almost all build steps why doesnt json have trailing commas :( * rm build steps from sr * make equipped build title button-like (#1629) * make equipped build title button-like * format * make build TC title more button-like * only deploy if build was a success (#1633) * Create PRs in `new-release.yml` (#1631) * yep * fixes * allow squash merges * fix typo * typo2 * printf * Convert Pagination to infinite scroll (#1627) * Infinite scroll experiment on artifacts page * convert all pagination to infinite scroll * add inf scroll to art exclusion * fix typecheck in mini-ci (#1636) * fix typecheck in mini-ci * typecheck first * move teambuff to team overview (#1632) * move teambuff to team overview * update team button to settings icon * non full-width add button * Add teams page filter (#1639) * Add teams page filter * format * additional features * fix translation * Add `teams` tab to mobile UI (#1654) * Update teamcard (#1653) * update teamcard * remove unnecessary divider * more colorful teammate selector * update migration naming (#1658) * update migration naming * add migration for GO migration on import * Open Team Editor after creating team from character editor (#1655) * Open Team Editor after creating team from character editor * remove console.log * Show loadout + build name on teamcard hover (#1656) * show loadout + build name on teamcard hover * update teamcard * fix team navigation (#1659) * Combine Loadout and Build settings into a singular popup (#1662) * fix SetEffectDisplay * fix build --------- Co-authored-by: frzyc <frzyc@users.noreply.github.com> Co-authored-by: eeeqeee <103794572+eeeqeee@users.noreply.github.com> Co-authored-by: HassnHamada <44922829+HassnHamada@users.noreply.github.com>

nguyentvan7 added 2 commits February 19, 2024 14:06

Split artifact config and hide filters/graph by default

d827b54

Change character filter state to be custom list by default

40e9869

nguyentvan7 added 7 commits February 19, 2024 14:16

Adjust tooltip location for graph

4c6c9ae

Fix bad width for tabs

4d3ef7c

Adjust sizing mechanism

8371d64

Merge branch 'master' into van/go/simplifyOpt

5b170b4

Reintegrate artifact cond config

936c9fd

Fix error

1d2ff9a

Update default db

5bf0450

nguyentvan7 changed the title ~~Simplify optimization tab, add artifact config tab~~ Simplify optimization tab Mar 5, 2024

nguyentvan7 added 4 commits March 5, 2024 19:49

Fix format

98a6adb

Fix bad merge

8fb1107

Fix layout and typo

7549df2

Fix lint and layout

f6d5d14

nguyentvan7 requested a review from frzyc March 5, 2024 21:09

frzyc requested changes Mar 5, 2024

View reviewed changes

nguyentvan7 added 2 commits March 5, 2024 19:21

Fix strings

1b514ff

Fix accordion styling

8b0ea5e

nguyentvan7 added 4 commits March 5, 2024 22:40

Reduce padding on set conditionals

4fd2392

Modify header

9760e48

Rename component and adjust header

83e9c0b

Add back teammate build button

bb29ae6

nguyentvan7 requested a review from frzyc March 6, 2024 06:04

frzyc previously approved these changes Mar 6, 2024

View reviewed changes

Update OptConfigDataManager.ts

2092456

nguyentvan7 dismissed frzyc’s stale review via 2092456 March 8, 2024 17:25

Update OptConfigDataManager.ts

1ef1fb8

nguyentvan7 requested a review from frzyc March 12, 2024 02:45

frzyc mentioned this pull request Mar 12, 2024

Frzyc/go/simplify opt #1666

Merged

5 tasks

frzyc and others added 3 commits March 12, 2024 12:59

Revert "Frzyc/go/simplify opt (#1666)" (#1668)

0196ffe

This reverts commit ca73f9f.

frzyc mentioned this pull request Mar 21, 2024

Separate the artifact conditional and artifact set config in opt tab #1805

Open

frzyc marked this pull request as draft April 15, 2024 00:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify optimization tab #1514

Simplify optimization tab #1514

nguyentvan7 commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

frzyc left a comment

frzyc commented Mar 5, 2024

frzyc commented Mar 5, 2024 •

edited

frzyc commented Mar 6, 2024

nguyentvan7 commented Mar 6, 2024

Simplify optimization tab #1514

Are you sure you want to change the base?

Simplify optimization tab #1514

Conversation

nguyentvan7 commented Feb 19, 2024 • edited

Describe your changes

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

github-actions bot commented Feb 19, 2024 • edited

frzyc left a comment

Choose a reason for hiding this comment

frzyc commented Mar 5, 2024

frzyc commented Mar 5, 2024 • edited

frzyc commented Mar 6, 2024

nguyentvan7 commented Mar 6, 2024

nguyentvan7 commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

frzyc commented Mar 5, 2024 •

edited