parser state no longer remains stuck on 'Loading references' - parser is pretty much stable!

Author: retailcoder

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -135,14 +135,24 @@ private void ParseAll()
 
             var components = projects.SelectMany(p => p.VBComponents.Cast<VBComponent>()).ToList();
             var modified = components.Where(_state.IsModified).ToList();
+            var unchanged = components.Where(c => !_state.IsModified(c)).ToList();
 
-            _state.SetModuleState(ParserState.LoadingReference);
+            _state.SetModuleState(ParserState.LoadingReference); // todo: change that to a simple statusbar text update
             LoadComReferences(projects);
 
+            if (!modified.Any())
+            {
+                return;
+            }
+
             foreach (var component in modified)
             {
                 _state.SetModuleState(component, ParserState.Pending);
             }
+            foreach (var component in unchanged)
+            {
+                _state.SetModuleState(component, ParserState.Parsed);
+            }
 
             // invalidation cleanup should go into ParseAsync?
             foreach (var invalidated in _componentAttributes.Keys.Except(components))
@@ -152,8 +162,6 @@ private void ParseAll()
 
             foreach (var vbComponent in modified)
             {
-                while (!_state.ClearDeclarations(vbComponent)) { }
-
                 ParseAsync(vbComponent, CancellationToken.None);
             }
         }
@@ -194,11 +202,6 @@ private void LoadComReferences(IEnumerable<VBProject> projects)
             }
         }
 
-        public void LoadNewComReferences()
-        {
-            LoadComReferences(_state.Projects);
-        }
-
         public void UnloadComReference(Reference reference)
         {
             var referenceId = reference.ReferenceId();