Merge pull request #2368 from MDoerner/IgnoreQFforNonReturningFunction

IgnoreOnce quickfix for NonReturningFunction inspection in interface case

Author: retailcoder

RetailCoder.VBE/Inspections/NonReturningFunctionInspectionResult.cs

@@ -17,7 +17,10 @@ public NonReturningFunctionInspectionResult(IInspection inspection,
             : base(inspection, qualifiedContext.ModuleName, qualifiedContext.Context, target)
         {
             _quickFixes = isInterfaceImplementation 
-                ? new CodeInspectionQuickFix[] { }
+                ? new CodeInspectionQuickFix[] 
+                {
+                    new IgnoreOnceQuickFix(Context, QualifiedSelection, Inspection.AnnotationName),
+                }
                 : new CodeInspectionQuickFix[]
                 {
                     new ConvertToProcedureQuickFix(Context, QualifiedSelection, target),

RubberduckTests/Inspections/NonReturningFunctionInspectionTests.cs

@@ -477,7 +477,7 @@ public void GivenParameterizedPropertyGetter_QuickFixKeepsParameter()
 
         [TestMethod]
         [TestCategory("Inspections")]
-        public void NonReturningFunction_ReturnsResult_InterfaceImplementation_NoQuickFix()
+        public void NonReturningFunction_ReturnsResult_InterfaceImplementation_OnlyIgnoreOnceQuickFix()
         {
             //Input
             const string inputCode1 =
@@ -507,7 +507,8 @@ Function IClass1_Foo() As Boolean
             var inspection = new NonReturningFunctionInspection(parser.State);
             var inspectionResults = inspection.GetInspectionResults();
 
-            Assert.AreEqual(0, inspectionResults.First().QuickFixes.Count());
+            Assert.IsTrue(inspectionResults.First().QuickFixes.Any() 
+                && inspectionResults.First().QuickFixes.All(quickfix => quickfix.Description == InspectionsUI.IgnoreOnce));
         }
 
         [TestMethod]