Merge pull request #4559 from MDoerner/FixSomeScwDisposal

Fix some scw disposal

Author: retailcoder

Rubberduck.CodeAnalysis/Inspections/Concrete/SheetAccessedUsingStringInspection.cs

@@ -96,7 +96,7 @@ private IVBComponent GetVBComponentMatchingSheetName(IdentifierReferenceInspecti
 
             var sheetArgumentContext = indexExprContext.argumentList().argument(0);
             var sheetName = FormatSheetName(sheetArgumentContext.GetText());
-            var project = State.Projects.First(p => p.ProjectId == reference.QualifiedName.ProjectId);
+            var project = State.ProjectsProvider.Project(reference.QualifiedName.ProjectId);
 
             using (var components = project.VBComponents)
             {

Rubberduck.Core/UI/Inspections/InspectionResultsViewModel.cs

@@ -620,7 +620,7 @@ private bool CanExecuteCopyResultsCommand(object parameter)
             return !IsBusy && _resultsAll != null && _resultsAll.Any();
         }
 
-        public Visibility EmptyUIRefreshVisibility => _state.Projects.Count > 0 ? Visibility.Hidden : Visibility.Visible;
+        public Visibility EmptyUIRefreshVisibility => _state.ProjectsProvider.Projects().Any() ? Visibility.Hidden : Visibility.Visible;
 
         public Visibility EmptyUIRefreshMessageVisibility => IsBusy ? Visibility.Hidden : Visibility.Visible;
 

Rubberduck.Core/UI/UnitTesting/Commands/AddTestModuleCommand.cs

@@ -125,13 +125,13 @@ private string DeclarationFormatFor(string declarationFormat, string type, IUnit
 
         private IVBProject GetProject()
         {
-            using (var activeProject = _vbe.ActiveVBProject)
+            //No using because the wrapper gets returned potentially. 
+            var activeProject = _vbe.ActiveVBProject;
+            if (!activeProject.IsWrappingNullReference)
             {
-                if (!activeProject.IsWrappingNullReference)
-                {
-                    return activeProject;
-                }
+                return activeProject;
             }
+            activeProject.Dispose();
 
             using (var projects = _vbe.VBProjects)
             {
@@ -143,10 +143,13 @@ private IVBProject GetProject()
 
         protected override bool EvaluateCanExecute(object parameter)
         {
+            bool canExecute;
             using (var project = GetProject())
             {
-                return project != null && !project.IsWrappingNullReference && CanExecuteCode(project);
+                canExecute = project != null && !project.IsWrappingNullReference && CanExecuteCode(project);
             }
+
+            return canExecute;
         }
 
         private bool CanExecuteCode(IVBProject project)

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -423,7 +423,7 @@ public void SetModuleState(QualifiedModuleName module, ParserState state, Cancel
             if (AllUserDeclarations.Any())
             {
                 var projectId = module.ProjectId;
-                IVBProject project = GetProject(projectId);
+                var project = GetProject(projectId);
 
                 if (project == null)
                 {

Rubberduck.Parsing/VBA/StateProjectManagerBase.cs

@@ -11,7 +11,7 @@ public abstract class StateProjectManagerBase : IProjectManager
         private readonly RubberduckParserState _state;
         private readonly IVBE _vbe;
 
-        public StateProjectManagerBase(
+        protected StateProjectManagerBase(
             RubberduckParserState state,
             IVBE vbe)
         {

Rubberduck.VBEEditor/SourceCodeHandling/CodePaneSourceCodeHandler.cs

@@ -283,7 +283,8 @@ public CodeString GetCurrentLogicalLine(QualifiedModuleName module)
 
         public Selection GetSelection(QualifiedModuleName module)
         {
-            using (var component = _projectsProvider.Component(module))
+            var component = _projectsProvider.Component(module);
+
             using (var codeModule = component.CodeModule)
             using (var pane = codeModule.CodePane)
             {