added failing test for SynchronizeAttributesQuickFix: Missing PredeclaredId attribute fix (changes "= False" to "= True")

Author: retailcoder

Rubberduck.Inspections/QuickFixes/SynchronizeAttributesQuickFix.cs

@@ -57,7 +57,21 @@ public void Fix(IInspectionResult result)
             }
             else
             {
-                Debug.Assert(false, "bug: inspection result has a null membername");
+                var moduleName = result.QualifiedSelection.QualifiedName;
+
+                var attributeContext = context as VBAParser.AttributeStmtContext;
+                if(attributeContext != null)
+                {
+                    Fix(moduleName, attributeContext);
+                    return;
+                }
+
+                var annotationContext = context as VBAParser.AnnotationContext;
+                if(annotationContext != null)
+                {
+                    Fix(moduleName, annotationContext);
+                    return;
+                }
             }
         }
 
@@ -71,6 +85,16 @@ private void Fix(QualifiedMemberName memberName, VBAParser.AttributeStmtContext
 
         }
 
+        private void Fix(QualifiedModuleName moduleName, VBAParser.AttributeStmtContext context)
+        {
+            
+        }
+
+        private void Fix(QualifiedModuleName moduleName, VBAParser.AnnotationContext context)
+        {
+            
+        }
+
         /// <summary>
         /// Adds an attribute to match given annotation.
         /// </summary>

RubberduckTests/Inspections/SynchronizeAttributesQuickFixTests.cs

@@ -0,0 +1,68 @@
+using System.Linq;
+using System.Threading;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Rubberduck.Inspections.Concrete;
+using Rubberduck.Inspections.QuickFixes;
+using Rubberduck.Parsing.Grammar;
+using Rubberduck.VBEditor.SafeComWrappers;
+using Rubberduck.VBEditor.SafeComWrappers.Abstract;
+using RubberduckTests.Mocks;
+
+namespace RubberduckTests.Inspections
+{
+    [TestClass]
+    public class SynchronizeAttributesQuickFixTests
+    {
+        [TestMethod]
+        public void AddsMissingPredeclaredIdAttribute()
+        {
+            const string testModuleName = "Test";
+            const string inputCode = @"
+VERSION 1.0 CLASS
+BEGIN
+  MultiUse = -1  'True
+END
+Attribute VB_Name = """ + testModuleName + @"""
+Attribute VB_GlobalNameSpace = False
+Attribute VB_Creatable = False
+Attribute VB_PredeclaredId = False
+Attribute VB_Exposed = False
+Option Explicit
+'@PredeclaredId
+";
+            const string expectedCode = @"
+VERSION 1.0 CLASS
+BEGIN
+  MultiUse = -1  'True
+END
+Attribute VB_Name = """ + testModuleName + @"""
+Attribute VB_GlobalNameSpace = False
+Attribute VB_Creatable = False
+Attribute VB_PredeclaredId = True
+Attribute VB_Exposed = False
+Option Explicit
+'@PredeclaredId
+";
+
+            IVBComponent component;
+            var vbe = MockVbeBuilder.BuildFromSingleModule(inputCode, testModuleName, ComponentType.ClassModule, out component);
+
+            var state = MockParser.CreateAndParse(vbe.Object);
+            var inspection = new MissingAttributeInspection(state);
+            var inspector = InspectionsHelper.GetInspector(inspection);
+            var result = inspector.FindIssuesAsync(state, CancellationToken.None).Result?.SingleOrDefault();
+            if(result?.Context.GetType() != typeof(VBAParser.AnnotationContext))
+            {
+                Assert.Inconclusive("Inspection failed to return a result.");
+            }
+
+            var fix = new SynchronizeAttributesQuickFix(state);
+            fix.Fix(result);
+
+            var rewriter = state.GetAttributeRewriter(result.QualifiedSelection.QualifiedName);
+            var actual = rewriter.GetText();
+
+            Assert.AreEqual(expectedCode, actual);
+        }
+    }
+}

RubberduckTests/RubberduckTests.csproj

@@ -107,6 +107,7 @@
     <Compile Include="Inspections\OptionBaseZeroInspectionTests.cs" />
     <Compile Include="Inspections\PassParameterByReferenceQuickFixTests.cs" />
     <Compile Include="Inspections\QuickFixProviderTests.cs" />
+    <Compile Include="Inspections\SynchronizeAttributesQuickFixTests.cs" />
     <Compile Include="Inspections\UndeclaredVariableInspectionTests.cs" />
     <Compile Include="Mocks\TestAttributeParser.cs" />
     <Compile Include="Parsing\Coordination\IModuleToModuleReferenceManagerTestBase.cs" />