Merge pull request #3991 from mansellan/3951

Handle nameless parameters in referenced COM libraries.

Author: retailcoder

Rubberduck.Parsing/ComReflection/ComMember.cs

@@ -91,7 +91,7 @@ private void LoadParameters(FUNCDESC funcDesc, ITypeInfo info)
             {
                 var paramPtr = new IntPtr(funcDesc.lprgelemdescParam.ToInt64() + Marshal.SizeOf(typeof(ELEMDESC)) * index);
                 var elemDesc = (ELEMDESC)Marshal.PtrToStructure(paramPtr, typeof(ELEMDESC));
-                var param = new ComParameter(elemDesc, info, names[index + 1]);
+                var param = new ComParameter(elemDesc, info, names[index + 1] ?? $"{index}unnamedParameter");
                 Parameters.Add(param);
             }
             if (Parameters.Any() && funcDesc.cParamsOpt == -1)

Rubberduck.Parsing/ComReflection/ComParameter.cs

@@ -56,6 +56,8 @@ public string TypeName
 
         public ComParameter(ELEMDESC elemDesc, ITypeInfo info, string name)
         {
+            Debug.Assert(name != null, "Parameter name is null");
+
             Name = name;
             var paramDesc = elemDesc.desc.paramdesc;
             GetParameterType(elemDesc.tdesc, info);

Rubberduck.Parsing/VBA/COMReferenceSynchronizerBase.cs

@@ -175,7 +175,12 @@ private string GetReferenceProjectId(IReference reference, IReadOnlyList<IVBProj
 
         protected void LoadReference(IReference localReference, ConcurrentBag<IReference> unmapped)
         {
-            Logger.Trace(string.Format("Loading referenced type '{0}'.", localReference.Name));
+            if (Thread.CurrentThread.IsBackground && Thread.CurrentThread.Name == null)
+            {
+                Thread.CurrentThread.Name = $"LoadReference '{localReference.Name}'";
+            }
+
+            Logger.Trace(string.Format("Loading referenced type '{0}'.", localReference.Name));            
             var comReflector = new ReferencedDeclarationsCollector(_state, localReference, _serializedDeclarationsPath);
             try
             {