Fix the logic for setting the completed state of the suspension result and fix a bad unit test.

Author: bclothier

Rubberduck.Parsing/VBA/ParseCoordinator.cs

@@ -132,6 +132,11 @@ public void SuspendRequested(object sender, RubberduckStatusSuspendParserEventAr
                     CancellationToken.None);
                 e.BusyAction.Invoke();
             }
+            catch
+            {
+                e.Result = SuspensionResult.UnexpectedError;
+                throw;
+            }
             finally
             {
                 lock (SuspendStackSyncObject)
@@ -153,13 +158,17 @@ public void SuspendRequested(object sender, RubberduckStatusSuspendParserEventAr
                         // evaluation to the state manager.
                         _parserStateManager.EvaluateOverallParserState(CancellationToken.None);
                     }
-                    e.Result = SuspensionResult.Completed;
                 }
 
                 if (ParsingSuspendLock.IsWriteLockHeld)
                 {
                     ParsingSuspendLock.ExitWriteLock();
                 }
+
+                if (e.Result == SuspensionResult.Pending)
+                {
+                    e.Result = SuspensionResult.Completed;
+                }
             }
 
             // Any reparse requests must be done outside the write lock to avoid deadlocks

RubberduckTests/ParserState/ParserStateTests.cs

@@ -242,7 +242,7 @@ public void Test_RPS_SuspendParser_Interrupted_Deadlock()
                 result2.Wait(token);
             }
             Assert.IsFalse(wasSuspended, "wasSuspended was set to true");
-            Assert.AreEqual(SuspensionResult.Completed, result);
+            Assert.AreEqual(SuspensionResult.TimedOut, result);
         }
 
         [Test]