Fix the PromptToUninstall to use the localized app mode, rather than the code-only constants.

Author: bclothier

Rubberduck.Deployment/InnoSetup/Includes/English.CustomMessages.iss

@@ -16,7 +16,7 @@ English.RegisterAddInCaption=Register VBE Add-in
 English.RegisterAddInMessage=Perform user registration of VBE addin.
 English.RegisterAddInDescription=VBE Add-ins are registered on a per-user basis, even if the VBE add-in was installed for all users. Therefore, this must be executed on a per-user basis.
 English.RegisterAddInButtonCaption=Register the Rubberduck VBE Add-in
-English.WillExecuteAdminInstall=Rubberduck Add-In will be available to all users.%n%nNOTE: each user individually must register the Rubberduck Add-In as%nthis is a per-user setting and cannot be deployed to all users.%n%nAfter installing, a shortcut named "Repair VBE Addin registration" under the "Rubberduck" folder will be available to all users.
+English.WillExecuteAdminInstall=Rubberduck Add-In will be available to all users.%n%nNOTE: each user individually must register the Rubberduck Add-In as%nthis is a per-user setting and cannot be deployed to all users.%n%nAfter installing, a shortcut named "Repair VBE Addin registration" under the%nRubberduck's program folder will be available to all users.
 English.WillLaunchAdminInstall=The installer will request for admin privilege to install for all users and will%nresume afterward to perform the add-in registration.
 English.WillInstallForCurrentUser=Rubberduck Add-In will be made available to the current user only and will not%nrequire admin privileges.
 English.UninstallOldVersionPrompt=There seems to be a previous version of Rubberduck, installed in %s mode, and it should be uninstalled. Proceed?

Rubberduck.Deployment/InnoSetup/Installer Build Script.iss

@@ -137,9 +137,9 @@ const
    ///Identifiers for installation in everyone mode to support
    ///functions that needs to distinguish between install modes.
    ///</remarks>
-   EveryoneAppMode = 'Everyone';
+   EveryoneAppMode = 'AllUsers';
    EveryoneAppId = '{979AFF96-DD9E-4FC2-802D-9E0C36A60D09}';
-   PerUserAppMode = 'PerUser';
+   PerUserAppMode = 'CurrentUser';
    PerUserAppId = '{DF0E0E6F-2CED-482E-831C-7E9721EB66AA}';
    
   ///<remarks>
@@ -706,9 +706,14 @@ end;
 function PromptToUninstall(AppMode: string): boolean;
 var
   ErrorCode: integer;
+  LocalizedMode: string;
 begin
   Log('A previous version of ' + AppMode + ' was detected; prompting the user whether to uninstall');
-  if IDYES = MsgBox(Format(ExpandConstant('{cm:UninstallOldVersionPrompt}'), [AppMode]), mbConfirmation, MB_YESNO) then
+  if AppMode = EveryoneAppMode then
+    LocalizedMode := ExpandConstant('{cm:Everyone}')
+  else if AppMode = PerUserAppMode then
+    LocalizedMode := ExpandConstant('{cm:PerUser}');
+  if IDYES = MsgBox(Format(ExpandConstant('{cm:UninstallOldVersionPrompt}'), [LocalizedMode]), mbConfirmation, MB_YESNO) then
   begin
     ErrorCode := -1;
     ErrorCode := UnInstallOldVersion(GetAppId(AppMode));