fixed a few tests that break when executed in a fr-CA locale

Author: retailcoder

Rubberduck.Parsing/Preprocessing/DecimalValue.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 
 namespace Rubberduck.Parsing.Preprocessing
 {
@@ -55,13 +56,13 @@ public string AsString
         {
             get
             {
-                return _value.ToString();
+                return _value.ToString(CultureInfo.InvariantCulture);
             }
         }
 
         public override string ToString()
         {
-            return _value.ToString();
+            return _value.ToString(CultureInfo.InvariantCulture);
         }
     }
 }

Rubberduck.Parsing/Preprocessing/StringValue.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics;
 using System.Globalization;
 
 namespace Rubberduck.Parsing.Preprocessing
@@ -28,29 +29,30 @@ public bool AsBool
                 {
                     return false;
                 }
-                var str = _value;
-                if (string.CompareOrdinal(str.ToLower(), "true") == 0
-                    || string.CompareOrdinal(str, "#TRUE#") == 0)
+                var value = _value;
+                if (string.CompareOrdinal(value.ToLower(), "true") == 0 || string.CompareOrdinal(value, "#TRUE#") == 0)
                 {
                     return true;
                 }
-                else if (string.CompareOrdinal(str.ToLower(), "false") == 0
-                    || string.CompareOrdinal(str, "#FALSE#") == 0)
+                
+                if (string.CompareOrdinal(value.ToLower(), "false") == 0 || string.CompareOrdinal(value, "#FALSE#") == 0)
                 {
                     return false;
                 }
-                else
-                {
-                    decimal number = AsDecimal;
-                    return new DecimalValue(number).AsBool;
-                }
+                
+                return new DecimalValue(AsDecimal).ToString() != "0"; // any non-zero value evaluates to TRUE in VBA
             }
         }
 
         public byte AsByte
         {
             get
             {
+                byte value;
+                if (byte.TryParse(_value, NumberStyles.Float, CultureInfo.InvariantCulture, out value))
+                {
+                    return value;
+                }
                 return byte.Parse(_value, NumberStyles.Float);
             }
         }
@@ -59,10 +61,10 @@ public DateTime AsDate
         {
             get
             {
-                DateTime date;
-                if (DateTime.TryParse(_value, out date))
+                DateTime value;
+                if (DateTime.TryParse(_value, out value))
                 {
-                    return date;
+                    return value;
                 }
                 decimal number = AsDecimal;
                 return new DecimalValue(number).AsDate;
@@ -73,7 +75,13 @@ public decimal AsDecimal
         {
             get
             {
-                return decimal.Parse(_value, NumberStyles.Float);
+                decimal value;
+                if (decimal.TryParse(_value, NumberStyles.Float, CultureInfo.InvariantCulture, out value))
+                {
+                    return value;
+                }
+                Debug.Assert(false); // this line was never hit in any unit test covering it.
+                return 0;
             }
         }
 
@@ -87,7 +95,7 @@ public string AsString
 
         public override string ToString()
         {
-            return _value.ToString();
+            return _value;
         }
     }
 }

RubberduckTests/Preprocessing/VBAPreprocessorVisitorTests.cs

@@ -376,7 +376,7 @@ public void TestCStrFunction()
             Assert.AreEqual(string.Empty, result.Item1.Get("b").AsString);
             Assert.AreEqual("True", result.Item1.Get("c").AsString);
             Assert.AreEqual("False", result.Item1.Get("d").AsString);
-            Assert.AreEqual(345.23.ToString(), result.Item1.Get("e").AsString);
+            Assert.AreEqual(345.23.ToString(CultureInfo.InvariantCulture), result.Item1.Get("e").AsString);
             Assert.AreEqual(new DateTime(1899, 12, 30, 2, 1, 0).ToLongTimeString(), result.Item1.Get("f").AsString);
             Assert.AreEqual(new DateTime(2016, 1, 31).ToShortDateString(), result.Item1.Get("g").AsString);
         }