Merge pull request #1889 from Hosch250/Issue1852

Don't let manually loading the built-in declarations happen until the…

Author: Hosch250

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -360,6 +360,8 @@ private string GetReferenceProjectId(Reference reference, IReadOnlyList<VBProjec
 
         private void SyncComReferences(IReadOnlyList<VBProject> projects)
         {
+            var loadTasks = new List<Task>();
+
             foreach (var vbProject in projects)
             {
                 var projectId = QualifiedModuleName.GetProjectId(vbProject);
@@ -393,6 +395,7 @@ private void SyncComReferences(IReadOnlyList<VBProject> projects)
                     {
                         _state.OnStatusMessageUpdate(ParserState.LoadingReference.ToString());
 
+                        loadTasks.Add(
                         Task.Run(() =>
                         {
                             var comReflector = new ReferencedDeclarationsCollector(_state);
@@ -402,7 +405,7 @@ private void SyncComReferences(IReadOnlyList<VBProject> projects)
                             {
                                 _state.AddDeclaration(declaration);
                             }
-                        });
+                        }));
                         map.IsLoaded = true;
                     }
                 }
@@ -426,6 +429,8 @@ private void SyncComReferences(IReadOnlyList<VBProject> projects)
                 }
             }
 
+            Task.WaitAll(loadTasks.ToArray());
+
             foreach (var reference in unmapped)
             {
                 UnloadComReference(reference, projects);