This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix criterion display #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InclusiveCriterion has a default state called "none", this state was displayed through default Criterion behavior which is: if no valid state is available, let's display "<none>". This patch test explicitly the default value when formatting the state of an InclusiveCriterion. It also introduces the test getLiteralValue return when formatting a standard Criterion rather than testing the generated string emptiness. A difference can now be made between an inclusive criterion default value and an exclusive criterion with an unknown state. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Criterion type, which can be inclusive or exclusive is displayed sometimes with a capital letter and sometimes not. This patch corrects this behaviour to always have the first letter in capital. Signed-off-by: Jules Clero <julesx.clero@intel.com>
dawagner
added a commit
that referenced
this pull request
Jun 2, 2015
Fix criterion display Two criterion display fixes/improvements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two criterion display fixes/improvements.