This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Utility improvements #275
Merged
Utility improvements #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krocard
commented
Oct 9, 2015
krocard
commented
- asString now return the formated string leading to usage improvement
- Fully unit test Utility.h
- Simplify appendTitle implementation
- CommandHandler: simplify the message formating
-
General Comment
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> 👍 @dawagner please review
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> 100% coverage on Utility.cpp !
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'>
👍 - <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> @tcahuzax please review
- <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'>
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> @tcahuzax please review
-
- <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'> This is has a completely different effect than it previously had. Same comment in all places below.
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> True, it is completly wrong.
-
- <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'> I'm not sure this is needed in this particular case.
General Comment
krocard
force-pushed
the
utility-improvements
branch
5 times, most recently
from
a84b8a5 to
cdf01e0
Compare
|
👍 @dawagner please review |
parameter/ConfigurableDomain.cpp
Outdated
There was a problem hiding this comment.
This is has a completely different effect than it previously had. Same comment in all places below.
There was a problem hiding this comment.
True, it is completly wrong.
asString was not returning it's result, leading to more complicated usage. Return the formated string instead of using an output parameter. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
utility-improvements
branch
from
ef3d592 to
0cb551b
Compare
|
100% coverage on Utility.cpp ! |
|
|
|
@tcahuzax please review |
|
|
|
@tcahuzax please review |
Utility functions were not tested, introduce unit tests for all functions in Utility.h. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Use `std::string::string(size_t, char)` to simplify the construction of the help message. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Utility.h contain functions that were all part of a CUtility class. Nevertheless this class had no invariant nor asserting any invariant. Thus this class was only used for its namespace aspect. Use a real namespace instead. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
utility-improvements
branch
from
0cb551b to
9ffcd54
Compare
krocard
added a commit
that referenced
this pull request
Oct 13, 2015
Utility improvements: - asString now return the formated string leading to usage improvement - Fully unit test Utility.h - Simplify appendTitle implementation - CommandHandler: simplify the message formating
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.