Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accessibility statement from design.login.gov in favor of it being on login.gov #178

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

juliaelman
Copy link
Member

Login.gov has recently updated our content, look and feel to reflect our growing program. The accessibility content on design.login.gov is the same content that exists on login.gov.

A few things to note before reviewing this PR:

  1. The same content exists on login.gov, which is the main site for the program. This gives accessibility more prominence and importance to our efforts and the attention it deserves.
  2. Accessibility guidance will exist at the component level so that there is specific guidance for those components, rather than overarching guidance.
  3. This PR includes a re-direct to the new accessibility page on login.gov in case there are any lingering urls that used to link to this page on design.login.gov.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,6 @@ primary:
- href: /usage/
- href: /brand/
- href: /content/
- href: /accessibility/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to leave in some other way for this page to be navigable from the design site?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to leave in some other way for this page to be navigable from the design site?

I think the intention is to remove it completely from the design system website, and that the redirect exists largely to prevent dead links in case it's referenced elsewhere. @juliaelman can confirm though if this aligns to her expectations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachmargolis great question. Talked with Nick. We will be updating the design.login.gov footer to match the footer on login.gov so that the statement is added there and we have a consistency in branding.

@juliaelman juliaelman merged commit 415142c into main Jan 20, 2021
@juliaelman juliaelman deleted the je-remove-accessibility branch January 20, 2021 19:08
aduth added a commit that referenced this pull request Jan 20, 2021
**Why**: So that accessibility redirect introduced in #178 does redirect.

In addition to completed accessibility reports, Login.gov has compiled a page regarding accessibility policies.

[Login.gov accessibility policies]({% link accessibility/policies.md %})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove this page as well?

https://design.login.gov/accessibility/policies/

Since we don't link to it anywhere now.

aduth added a commit that referenced this pull request Jan 20, 2021
**Why**: As of #178, this page is no longer referenced.
aduth added a commit that referenced this pull request Jan 20, 2021
**Why**: So that accessibility redirect introduced in #178 does redirect.
aduth added a commit that referenced this pull request Jan 29, 2021
* Remove accessibility policies page

**Why**: As of #178, this page is no longer referenced.

* Exclude external redirect pages from sitemap

**Why**: Since removal, not intended to be content of the site to be indexed.

Reference: https://twitter.com/JohnMu/status/1031867308434759680

* Keep sitemap entry for redirected accessibility page

**Why**: Maybe it is useful, so that Googlebot can find the new canonical resource?

See: https://twitter.com/maxjpeters/status/1034288751030104064

* Add Images page with as adaptation of accessibility policies

* Update decorative text hidden guidance

See: #181 (comment)

* Move Illustration brand guidance principles to Images page

* Add introduction content to the images page.

* Remove unused illustration from images page.

* Remove outdated link to Illustration subsection

Moved to Images page in c722baa

* Remove unused id-confirm.svg image

Removed in 0ff6281

* Remove unused "Decorative Illustration" screenshot

Replaced with illustration graphics in c722baa

* Update header content for accessibility.

Co-authored-by: Julia Elman <julia.elman@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants