Fix issue with wrong values for overlapping bed-ranges #84
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of testing #83, we realized that some values were used multiple times in calculations.
Tracking this down, it seems that in
track.rs
, same ranges were used multiple times. This is the part of the code I recently updated to fix a separate issue, and might have been a new bug caused by solving the old.I have prepared a 10nt
d4
file mapped with two reads to test this:Expected total coverage would be
(3 * 2 + 3 * 1) / 10 = 0.9
Before the update:
After the change:
I have prepared a unit test based on this as part of the PR. This and other tests are succeeding, except two
remote-view
tests (which I don't think are related to this change).Would you be able to review @brentp ?