Skip to content

Commit 01ea453

Browse files
authored
Merge pull request #32 from 42BV/bug/docker-stops-wrong-container
Docker stop command runs the wrong argument
2 parents 59148f6 + 4212ac1 commit 01ea453

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
66

77
## Unreleased
8+
### Fixed
9+
- Issue [#31](https://github.com/42BV/spring-boot-docker-postgres/issues/31), **Docker stop command runs the wrong argument**; when the library notices another Docker container occupies the port that it needs to run on, a ```docker stop``` command is initiated for the port-occupying container. However, this logic was flawed, as it tried to stop a container with the same name as the container that had to be started. Fixed by using the proper container name.
810

911
## [0.7.1] - 2018-01-25
1012
### Fixed

src/main/java/nl/_42/boot/docker/postgres/DockerStopContainerCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class DockerStopContainerCommand extends DockerFiniteProcessRunner {
1818

1919
public DockerStopContainerCommand(DockerPostgresProperties properties) {
2020
super(COMMAND, properties);
21-
this.containerName = properties.getContainerName();
21+
this.containerName = properties.getContainerOccupyingPort();
2222
this.port = properties.getPort();
2323
}
2424

0 commit comments

Comments
 (0)