Add CTRL+D shortcut to duplicate #6629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSi
reviewed
Jun 7, 2024
| @@ -1420,6 +1433,7 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>( | |||
| { | |||
| label: i18n._(t`Duplicate`), | |||
| click: () => duplicateObject(item), | |||
| accelerator: 'CTRL+D', | |||
There was a problem hiding this comment.
This value does not respect the format we use, you can search accelerator in the repo to understand how you should write it.
AlexandreSi
reviewed
Jun 7, 2024
| @@ -750,6 +750,19 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>( | |||
| selectObjectFolderOrObjectWithContext, | |||
| ] | |||
| ); | |||
| React.useEffect( | |||
There was a problem hiding this comment.
Could you regroup this effect with the other one setting the onDelete shortcut? Also, you can add a comment to the one above the instanciation of keyboardShortcutsRef
AlexandreSi
requested changes
Jun 7, 2024
|
There is two PR for this feature I made another one at: |
|
Okay I am going to see this |
I think the strategy of having the shortcut defined on the tree view (as done in this PR #6629) is a better strategy. I'll look into it. |
osmaneTKT
added a commit
to osmaneTKT/GDevelop
that referenced
this pull request
Jun 17, 2024
I corrected accelerator and grouped onDelete with onDuplicate. I also added a comment to the one above the instantiation of keyboardShortcutsRef.
AlexandreSi
pushed a commit
that referenced
this pull request
Jul 17, 2024
I corrected accelerator and grouped onDelete with onDuplicate. I also added a comment to the one above the instantiation of keyboardShortcutsRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CTRL+D shortcut to duplicate #6194