Skip to content

Conversation

yeoshuheng
Copy link
Collaborator

  • unit test added
  • readme added
  • cleanup code to meet checkstyle requirements

@yeoshuheng yeoshuheng requested a review from 4ndrelim September 22, 2023 17:22
Copy link
Owner

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks shu heng!

@yeoshuheng
Copy link
Collaborator Author

have made changes as per comments

@yeoshuheng yeoshuheng requested a review from 4ndrelim January 11, 2024 08:12
Copy link
Owner

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add ine one more test case focusing on duplicate numbers. feel free to add in more edge cases.

@4ndrelim 4ndrelim merged commit 2753a1f into 4ndrelim:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants