fix: Update OutputItem to align with OpenAI's Specification
#426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64bit
requested changes
Sep 1, 2025
There was a problem hiding this comment.
Looks like this PR is updating incorrect type, the Response object output field type is OutputContent
https://github.com/64bit/async-openai/blob/main/async-openai/src/types/responses.rs#L1371
The |
64bit
approved these changes
Sep 7, 2025
gilljon
pushed a commit
to gilljon/async-openai
that referenced
this pull request
Sep 22, 2025
* fix(types)!: change AssistantStreamEvent field name (64bit#400) BREAKING CHANGES: changed AssistantStreamEvent filed name * Fix typo in `ChatCompletionToolChoiceOption` docs (64bit#401) * feat: update image generation API to match latest OpenAI specs (64bit#402) * feat: update image generation API to match latest OpenAI specs - Add ImageModeration enum with 'auto' (default) and 'low' values - Add moderation parameter to CreateImageRequest for gpt-image-1 - Extend ImageQuality enum to support 'high', 'medium', 'low' for gpt-image-1 These changes align with the latest OpenAI API documentation for image generation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * add Auto to ImageQuality --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com> * fix(deps): bump to rand@0.9.0 (64bit#409) Signed-off-by: Nick Mitchell <nickm@us.ibm.com> * feat: Add `minimal` reasoning effort for gpt-5 (64bit#411) * add Scale and Priority to ServiceTier (64bit#416) * Add streaming support for Responses API (64bit#405) * Add streaming support for Responses API. * Update examples/responses-stream/src/main.rs * Update examples/responses-stream/src/main.rs * Update examples/responses-stream/src/main.rs * Delete async-openai/tests/responses.rs --------- Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com> * chore: Release * Add skip_serializing_if to more option types (64bit#412) Signed-off-by: John Howard <john.howard@solo.io> * Add Scale and Priority to the `ServiceTier` enum for the Responses API (64bit#419) * Fix schema of code interpreter call output (64bit#420) * chore: Release * fix: CompoundFilter should use CompoundType instead (64bit#429) * fix: Update `OutputItem` to align with OpenAI's Specification (64bit#426) * Update `OutputItem` to align with OpenAI's Specification * Update * chore: Release --------- Signed-off-by: Nick Mitchell <nickm@us.ibm.com> Signed-off-by: John Howard <john.howard@solo.io> Co-authored-by: posky <pjm5810@gmail.com> Co-authored-by: lazymio <ziqiaokong@gmail.com> Co-authored-by: Siyuan Yan <44753941+Madoshakalaka@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Himanshu Neema <himanshun.iitkgp@gmail.com> Co-authored-by: Nick Mitchell <starpit@users.noreply.github.com> Co-authored-by: Timon Vonk <mail@timonv.nl> Co-authored-by: Kevin Zimmerman <4733573+kczimm@users.noreply.github.com> Co-authored-by: Kazzix <kazzix14@gmail.com> Co-authored-by: John Howard <john.howard@solo.io> Co-authored-by: Advayp <69655599+Advayp@users.noreply.github.com> Co-authored-by: the-spice-must-flow <63762528+the-spice-must-flow@users.noreply.github.com> Co-authored-by: Ben Levin <ben.levin@yurts.ai>
ifsheldon
pushed a commit
to ifsheldon/async-openai-wasm
that referenced
this pull request
Sep 26, 2025
) * Update `OutputItem` to align with OpenAI's Specification * Update (cherry picked from commit a8bb897)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OutputItemshould be a tagged union. This PR updates that struct to align with OpenAI's specification