Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- OuterWdith() is used instead of width() which fixes issues with Bootst... #4

Closed
wants to merge 1 commit into from

Conversation

afromogli
Copy link

...rap 3:s box-sizing: border-box. Described more in detail in issue: mleibman/SlickGrid#742

…tstrap 3:s box-sizing: border-box. Described more in detail in issue: mleibman/SlickGrid#742
@afromogli
Copy link
Author

One thing I forgot to test was to run SlickGrid without Bootstrap 3... So be sure to test that! (Or close this pull request :P )

@6pac
Copy link
Owner

6pac commented Apr 10, 2015

I left some comments on #742. This is in my queue of things to look at, but the fix is easy, just disable border-box for the slickgrid elements. I have to do regression testing.

@afromogli
Copy link
Author

Ok, I actually tried to disable border-box using CSS (the fix is mentioned in mleibman/SlickGrid#742 by jcready) but it did not work... So be sure to do regression testing with and without Bootstrap 3!

@skosch
Copy link

skosch commented Apr 20, 2015

FWIW, this patch doesn't work for me with Bootstrap 3 :(

@afromogli
Copy link
Author

@skosch Hmm... strange, it worked for me.. Have you doublechecked that you have replaced all instances of width() with outerWidth()?

@skosch
Copy link

skosch commented Apr 23, 2015

You know what, after trying it again, it does work—once I resize one of the columns, that is, everything jumps into the right place. The autosize function does the trick, too.

(Unfortunately I now have another problem, namely that multiple grids on the same page all assume the same column widths ...)

@afromogli
Copy link
Author

Glad to hear it works for you!
Strange regarding the same column widths for multiple grids, we are also running multiple grids on same page without having this issue.. Did this issue appear after you used this fix?

@skosch
Copy link

skosch commented May 9, 2015

After ironing out a bunch of other problems, that problem has now disappeared. It seems like it was caused by jQuery selectors erroneously catching elements across mutliple grids, due to some weird interactions with another library I am using.

Note that for the header sizes to work properly, I also had to comment out the first if block in measureCellPaddingAndBorder (which was responsible for setting headerColumnWidthDiff incorrectly), in addition to replacing the width()s with outerWidth()s. Hopefully this helps the next guy ...

@6pac
Copy link
Owner

6pac commented Jun 2, 2015

I have now patched this problem and written a blog post. Release 2.2.3 includes the fix.
https://github.com/6pac/SlickGrid/releases
http://low-bandwidth.blogspot.com.au/2015/06/slickgrid-with-jqueryui-and-bootstrap.html

@6pac 6pac closed this Jun 2, 2015
@tanveer-ali
Copy link

I have to still enable the following slick.grid.css after getting the patch from @6pac in order to work in firefox the first grid loads .. it was misaligned

/box-sizing: content-box !important;/
to
box-sizing: content-box !important;

But enabling it fixed the issue. I am using jquery-ui-1.11.3 and bootstrap 3.3.4

arashdalir referenced this pull request in arashdalir/SlickGrid Feb 3, 2021
arashdalir referenced this pull request in arashdalir/SlickGrid Feb 3, 2021
attempt at new recursive search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants