-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- OuterWdith() is used instead of width() which fixes issues with Bootst... #4
Conversation
…tstrap 3:s box-sizing: border-box. Described more in detail in issue: mleibman/SlickGrid#742
One thing I forgot to test was to run SlickGrid without Bootstrap 3... So be sure to test that! (Or close this pull request :P ) |
I left some comments on #742. This is in my queue of things to look at, but the fix is easy, just disable border-box for the slickgrid elements. I have to do regression testing. |
Ok, I actually tried to disable border-box using CSS (the fix is mentioned in mleibman/SlickGrid#742 by jcready) but it did not work... So be sure to do regression testing with and without Bootstrap 3! |
FWIW, this patch doesn't work for me with Bootstrap 3 :( |
@skosch Hmm... strange, it worked for me.. Have you doublechecked that you have replaced all instances of width() with outerWidth()? |
You know what, after trying it again, it does work—once I resize one of the columns, that is, everything jumps into the right place. The autosize function does the trick, too. (Unfortunately I now have another problem, namely that multiple grids on the same page all assume the same column widths ...) |
Glad to hear it works for you! |
After ironing out a bunch of other problems, that problem has now disappeared. It seems like it was caused by jQuery selectors erroneously catching elements across mutliple grids, due to some weird interactions with another library I am using. Note that for the header sizes to work properly, I also had to comment out the first |
I have now patched this problem and written a blog post. Release 2.2.3 includes the fix. |
I have to still enable the following slick.grid.css after getting the patch from @6pac in order to work in firefox the first grid loads .. it was misaligned /box-sizing: content-box !important;/ But enabling it fixed the issue. I am using jquery-ui-1.11.3 and bootstrap 3.3.4 |
attempt at new recursive search
...rap 3:s box-sizing: border-box. Described more in detail in issue: mleibman/SlickGrid#742