-
Notifications
You must be signed in to change notification settings - Fork 0
Update 8hobbies/workflows digest to 35aaff6 #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jobs: | ||
lint: | ||
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63 | ||
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@35aaff65a539af824d36a72aac42393a71092cc9 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
To fix the detected issue, you should add the permissions
key to the workflow definition (.github/workflows/lint.yml) at the root level (above jobs), unless jobs require specific permissions. As the lint job appears to perform only linting, it is likely sufficient to set contents: read
. Place the permissions:
block immediately after the workflow name:
and before on:
, as recommended by GitHub best practices. No additional imports, definitions, or methods are needed; the only change is the YAML block addition.
-
Copy modified lines R16-R17
@@ -13,6 +13,8 @@ | ||
# limitations under the License. | ||
|
||
name: Lint | ||
permissions: | ||
contents: read | ||
|
||
on: | ||
push: |
jobs: | ||
run: | ||
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63 | ||
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@35aaff65a539af824d36a72aac42393a71092cc9 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
To address this issue, you should add a permissions
block to either the top level of .github/workflows/publish-dry-run.yml
or to the specific job under jobs:
. Since there is only a single job (run:
), the recommended approach is to place the permissions
key at the top level of the workflow file, just after the name:
and before on:
. This limits the permissions of GITHUB_TOKEN
for the entire workflow unless overridden by a job. As a minimal starting point, use permissions: {}
to fully restrict all default permissions. If your workflow requires specific permissions (for example, contents: read
for fetching code), set only those that are necessary for the workflow to function. In this case, since the workflow delegates all functionality to a reusable workflow, it is safest to start with the most restrictive block {}
and incrementally add needed permissions if jobs fail due to lack of access.
-
Copy modified line R16
@@ -13,6 +13,7 @@ | ||
# limitations under the License. | ||
|
||
name: Publish Dry Run | ||
permissions: {} | ||
|
||
on: | ||
push: |
jobs: | ||
test: | ||
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@9ce095e975915c75b3fb9243d3a49dfce7fffe63 | ||
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@35aaff65a539af824d36a72aac42393a71092cc9 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
To fix this issue, we should explicitly add a permissions:
block to the workflow file, .github/workflows/runtime.yml
, either at the root (which then applies to all jobs) or for the specific job (in this case, the only job is test
). Because this workflow only delegates to a reusable workflow (uses
), and unless we know more about what specific permissions are required, we should set contents: read
as the minimal safe default. If additional permissions (such as pull-requests: write
) are required by the reusable workflow, those should also be listed, but starting with the minimal case is appropriate. The edit is to insert a permissions:
block at the top level, immediately below name: Runtime
.
-
Copy modified lines R16-R17
@@ -13,6 +13,8 @@ | ||
# limitations under the License. | ||
|
||
name: Runtime | ||
permissions: | ||
contents: read | ||
|
||
on: | ||
push: |
This PR contains the following updates:
9ce095e
->35aaff6
Configuration
📅 Schedule: Branch creation - "on Sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.