Multi-thread landblock ticking (Landblock Groups w/Thread Safety) #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of "landblock group" ticking. The idea behind the landblock groups are that each group may contain multiple landblocks that must be ticked on the same thread, but, each group itself can be ticked on independant threads. The current groups are as follows: Every outdoor landblock is in a group Every dungeon landblock is in it's own group (one per dungeon) This is not ready for public servers yet.
Log.info is the default console output and is intended for: server startup connection/disconnections admin initiated command output server shutdown Log.Debug is the appropriate level for debug-type messages that are to be logged and audited at a later date, but not output to the console.
|
Have been using this WIP branch on my personal server for about seven days or so and have not encountered any issues with its inclusion. Admittedly, my server isn't very heavily used; however, the with the use it has gotten, no stability issues or bugs have been experienced. |
Thank you for the feedback. The config options have now been moved to config.js, see config.js.example for the new properties. |
Mag-nus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of "landblock group" ticking.
The idea behind the landblock groups are that each group may contain multiple landblocks that must be ticked on the same thread, but, each group itself can be ticked on independent threads.
Landblock groups describe their area using a rectangle. As landblocks are added (and removed) the rectangle that contains all the landblocks in the group is adjusted.
Landblocks are added to groups based on a minimum distance to the landblock groups rectangle.
In the event a landblock needs to be added and is within range of multiple groups, those groups will be combined into one.
Periodically, landblock groups are checked to see if they can be split. When a landblock group is split, it can result in a new group that has an overlapping rectangle to the parent group. This is not a problem because all the landblocks within each group meet the minimum distance requirements. In the event that a new landblock is added and is close to both rectangles, the groups will then be merged again.
Adding landblocks to groups is a very efficient process
Removing landblocks from groups is a very efficient process
Checking landblock groups for split potential does incur some overhead (~0.5 ms) which is why it's only done on intervals that are twice the Landblock.UnloadInterval.
Things still to do: Investigate more thread safety in the following scenarios
Creature OnDeath needs to examined.
Additional Changes we've had to made for thread safety
ToDo: