Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tox.ini and setup.py #223

Closed
wants to merge 3 commits into from
Closed

Conversation

avallbona
Copy link
Collaborator

@avallbona avallbona commented Jun 24, 2020

Fixes:

  • fixed tox django versions
  • fixed setup in order to install properly django
  • small refactor on setup to avoid duplicated code
  • small refactor on .travis.yml, reordered the environments for sake of clarity
  • added python and django versions to README.rst

The problem was that, how the setup.py was, on every tox environment always was executing django 3.0.7.
E.g.:
tox_env_example

Another problem was that, how the setup.py was, never was testing a version under 2.1.6.
E.g.:
setup_capture

fixed tox django versions
fixed setup in order to install properly django
@avallbona avallbona changed the title fix tox and setup fix tox.ini and setup.py Jun 24, 2020
Copy link
Collaborator

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file tests/testapp/puput.db is removed. Is this on purpose?

@avallbona
Copy link
Collaborator Author

The file tests/testapp/puput.db is removed. Is this on purpose?

It was ignored in the .gitignore file.

@avallbona
Copy link
Collaborator Author

@marctc I close the pr that I messed up. I create a new one.

@avallbona avallbona closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants