Fix dropped receive data caused by timeout #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set receive timeout to 500ms to prevent dropped data. Update the call in ESP8266::recv to call parser.process_oob rather than parser.recv since this code is only used to trigger the processing of out-of-band data.
c1728p9
force-pushed
the
fix_dropped_data_from_timeout
branch
from
f35f00a to
8f101bb
Compare
geky
approved these changes
Sep 7, 2017
| #endif | ||
| #ifndef ESP8266_RECV_TIMEOUT | ||
| #define ESP8266_RECV_TIMEOUT 0 | ||
| #define ESP8266_RECV_TIMEOUT 500 |
There was a problem hiding this comment.
Some quick math, 5 symbols (+IPD:) / 115200 baud = 0.043 ms.
500ms > 0.043ms so this looks good 👍
|
@marcuschangarm, @bentcooke, this may be a fix for the corruption issue you guys were seeing. |
|
Awesome! Can someone try the https://github.com/ARMmbed/mbed-stress-test please? I don't have access to an ESP module! 😄 |
|
Yes, I will try it with both the CC update and the stress test... though it may be tomorrow before I can get to it. I am having to setup a new laptop right now(old one died!). : ( |
|
Below is my output when I run |
|
Beautiful! Thank you Russ! 😄 |
|
Merge it in, ASAP. :-) |
|
I see we need a needs dependency label... |
|
I have been able to test this with a CC FW update config that was previously failing every time and it appears to have fixed the image corruption issue. Nice work Russ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set receive timeout to 500ms to prevent dropped data. Update the call to parser.recv to pass NULL rather than a dummy value so only out of band data is processed. This allows parser.recv to return immediately if there is no out of band data.
This patch also updates the ATParser library to bring in updated out of band data processing support.
This PR depends on ARMmbed/ATParser#14