Skip to content

Fix dropped receive data caused by timeout #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Fix dropped receive data caused by timeout #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ESP8266/ATParser.lib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://github.com/ARMmbed/ATParser/#77734ee44a63b149cd20a6647394ab781b67c0aa
https://github.com/ARMmbed/ATParser/#a2cb09990f11a17504608272966f1185b211ce23
4 changes: 2 additions & 2 deletions ESP8266/ESP8266.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@ int32_t ESP8266::recv(int id, void *data, uint32_t amount)
}
}

// Wait for inbound packet
if (!_parser.recv("OK")) {
// Check for inbound packets
if (!_parser.process_oob()) {
return -1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion ESP8266Interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#define ESP8266_SEND_TIMEOUT 500
#endif
#ifndef ESP8266_RECV_TIMEOUT
#define ESP8266_RECV_TIMEOUT 0
#define ESP8266_RECV_TIMEOUT 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick math, 5 symbols (+IPD:) / 115200 baud = 0.043 ms.

500ms > 0.043ms so this looks good 👍

#endif
#ifndef ESP8266_MISC_TIMEOUT
#define ESP8266_MISC_TIMEOUT 500
Expand Down