Function get_erase_size is declared incorrectly in QSPIFBlockDevice.h

[jporter4]

Function get_erase_size is declared incorrectly in QSPIFBlockDevice.h. It is missing the keyword 'const'.

Tested with external Flash device on Nordic nRF52840 based project. I would expect to see the same warning with any external QSPIF device.

5.14.1 and 5.15.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

EWARM 8.50

How is this defect reproduced ?

Include the file and compile.
It generates a warning only, so low severity.

[0xc0170]

Thanks for the report. @jporter4 Please send PR fixing it.

As it was tested on 5.15, is it also present on master?

[jporter4]

Hi, If you’re asking if the ‘const’ keyword is still missing in version 6.0.0 – yes, it is still missing: QSPIFBlockDevice.h: virtual mbed::bd_size_t get_erase_size(mbed::bd_addr_t addr); should be: virtual mbed::bd_size_t get_erase_size(mbed::bd_addr_t addr) const; From: Martin Kojtal <notifications@github.com> Sent: Friday, June 5, 2020 1:47 AM To: ARMmbed/mbed-os <mbed-os@noreply.github.com> Cc: Porter, Jack <JPorter4@moog.com>; Mention <mention@noreply.github.com> Subject: [EXTERNAL] Re: [ARMmbed/mbed-os] Function get_erase_size is declared incorrectly in QSPIFBlockDevice.h (#13061) Thanks for the report. @jporter4<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jporter4&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=LcYKx8FOvS9nsrkl0U8BdMwJNLlJ8jbTcAGwCyy-hIM&s=r08we8pMecNpGMhrsIp0dA2Of48a3T54emByyCHpDAo&e=> Please send PR fixing it. As it was tested on 5.15, is it also present on master? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ARMmbed_mbed-2Dos_issues_13061-23issuecomment-2D639316708&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=LcYKx8FOvS9nsrkl0U8BdMwJNLlJ8jbTcAGwCyy-hIM&s=OFU9Z_EFpJ2unN6oe1gR9R9AkjagrZgRxSUDC6G3Ce0&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ALTN3ZF6R3LHXYWLIX64WS3RVCPHFANCNFSM4NRSLEYA&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=LcYKx8FOvS9nsrkl0U8BdMwJNLlJ8jbTcAGwCyy-hIM&s=Y5MrxkGSXT7OS9SDx5bs-fc5WYBRlldG3LmTfi8SrkI&e=>. Confidentiality Notice: This electronic mail transmission is intended for the use of the individual or entity to which it is addressed and may contain confidential and/or proprietary information belonging to the sender. If you are not the intended recipient, you are hereby notified that any disclosure, use, copying, distribution, or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this transmission in error, please notify the sender immediately by e-mail and delete the original message. Thank you for your cooperation.

[adbridge]

@jporter4 when raising issues please do not delete sections from the template. All sections are required to be filled in. Thanks. We reserve the right to reject issues that do not contain sufficient information for us to reproduce correctly.

[jporter4]

If I deleted any sections, it was accidental. What information are you missing that you need to confirm a syntax error in a source file ? From: Anna Bridge <notifications@github.com> Sent: Friday, June 12, 2020 8:38 AM To: ARMmbed/mbed-os <mbed-os@noreply.github.com> Cc: Porter, Jack <JPorter4@moog.com>; Mention <mention@noreply.github.com> Subject: [EXTERNAL] Re: [ARMmbed/mbed-os] Function get_erase_size is declared incorrectly in QSPIFBlockDevice.h (#13061) @jporter4<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jporter4&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=nmwjuhzxSjY913A9jzAPygvw81F_ah2kbJThNh5piig&s=3N63MQ8Bba0Z5gXoke3qTjYdQr4TXSbq0WuJzTS4UyU&e=> when raising issues please do not delete sections from the template. All sections are required to be filled in. Thanks. We reserve the right to reject issues that do not contain sufficient information for us to reproduce correctly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ARMmbed_mbed-2Dos_issues_13061-23issuecomment-2D643305822&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=nmwjuhzxSjY913A9jzAPygvw81F_ah2kbJThNh5piig&s=Axdjvno5UwrLQlfLrs0qv72h_yqXyRMsj6Z199-RbRU&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ALTN3ZFMUUZJOUXROE2YMALRWI4TPANCNFSM4NRSLEYA&d=DwMCaQ&c=ByDrzdYw8tO08sJlHDO_Vg&r=gdcx7qxdTthQ5-qtdnXzUNQXixIFZZaUvFBm6Qgdrzc&m=nmwjuhzxSjY913A9jzAPygvw81F_ah2kbJThNh5piig&s=67wagWUQ262O_DUxkLcmhFYy2A1za_2aMiZA6OPoHl4&e=>. Confidentiality Notice: This electronic mail transmission is intended for the use of the individual or entity to which it is addressed and may contain confidential and/or proprietary information belonging to the sender. If you are not the intended recipient, you are hereby notified that any disclosure, use, copying, distribution, or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this transmission in error, please notify the sender immediately by e-mail and delete the original message. Thank you for your cooperation.

[0xc0170]

@jporter4 thanks for the confirmation. Can you send a pull request addressing this ?

[ciarmcom]

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2260