Add const keyword to get_erase_size declaration #13960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add const to function declaration. Const objects cannot access const safe functions, a compiler error is thrown if one tries to do so. This helps ensure that the object calling the method will not be modified. This is espescially desirable in functions where all we need to do is query existing data and not make any alterations.
ciarmcom
added
the
release-type: patch
|
@harmut01, thank you for your changes. |
0xc0170
approved these changes
Nov 25, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #13061
Const keyword added to declaration of get_erase_size. Const objects are only able to access const methods, without it a compiler error is raised when a const object attempts to use a non-const method. This change fixes this and removes related compiler warnings.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core @hugueskamba