Skip to content

Conversation

@rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 3, 2021

Summary of changes

  • No longer need to create mbed_os.lib and soft link to mbed-os as new --mbed-os-path command-line removes such dependency and creates mbed_build.cmake when passing mbed-os path with that command-line argument.

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @hugueskamba


- No longer need to create mbed_os.lib and soft link to mbed-os as new
 --mbed-os-path command-line removes such dependency and creates mbed_build.cmake
 when passing mbed-os path with that command line argument.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 3, 2021
@ciarmcom ciarmcom requested review from a team, 0xc0170 and hugueskamba March 3, 2021 12:30
@ciarmcom
Copy link
Member

ciarmcom commented Mar 3, 2021

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's time to add the testing to CI, isn't it?

@mergify mergify bot added needs: CI and removed needs: review labels Mar 3, 2021
@rajkan01
Copy link
Contributor Author

rajkan01 commented Mar 3, 2021

It's time to add the testing to CI, isn't it?

No, I requested one more change to Rob to add a set(MBED_PATH xyz_path) config into generated mbed_config.cmake whenever command line --mbed-os-path receives the mbed-os path which helps to avoid specify set(MBED_PATH) in every greentea test CMakeLists.txt file

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2021

CI started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants