Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Make CellularStateMachine timeouts configurable #10053

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
8 participants
@AriParkkila
Copy link
Contributor

commented Mar 12, 2019

Description

Make CellularStateMachine timeouts user configurable, as requested in #9735.

This change depends on PR #9937 (included so please review only the top commit).

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte and ARMmbed/mbed-os-maintainers Mar 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte

jarvte approved these changes Mar 12, 2019

@AnttiKauppila
Copy link
Contributor

left a comment

Those MACRO checks needs to be revisited

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 13, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-state-timeout branch from 56955aa to acbf534 Mar 25, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Those MACRO checks needs to be revisited

@AnttiKauppila do you mean that this should be implemented without MACROs?

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-state-timeout branch from acbf534 to 22e193c Apr 3, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@jarvte @AnttiKauppila changed implementation so that is does not have MACROs.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 3, 2019

@0xc0170

0xc0170 approved these changes Apr 3, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 3, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 3, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@jarvte please re-review

@jarvte

jarvte approved these changes Apr 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 5, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_cloud-client-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

restarted CI

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 5, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@AriParkkila This will need a rebase.

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-state-timeout branch from 4d28684 to e0f8b21 Apr 10, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

@cmonr this is now rebased and ready for merge.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 10, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 10, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Exporter restarted

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

CI job restarted: jenkins-ci/exporter

It's possible this PR might need a full rebuild. Something about the job being in a weird build state.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 12, 2019

@0xc0170 0xc0170 merged commit 4401d41 into ARMmbed:master Apr 15, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10321 cycles (+1152 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.