Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect excluded libraries into ignored_dirs #10173

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
6 participants
@theotherjimmy
Copy link
Contributor

commented Mar 20, 2019

Description

A few exporters use the resources ignored_dirs member to build a list
of directories to ignore when they scan the project for sources.

The requires section of mbed_app.json may filter a project to
include a specific set of libraries that it defines. However, this does
not update the resources.ignored_dirs member, and projects using
requires do not build when exported to gnuarmeclipse.

This PR tests this bug and corrects it.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Mar 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Set to rc4 as #10131 is also (fix needed there)

@0xc0170 0xc0170 requested a review from adbridge Mar 20, 2019

@bridadan
Copy link
Contributor

left a comment

Noice

@bulislaw
Copy link
Member

left a comment

🍩for the test!

@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@bulislaw I'm taking you up on that 🍩 😁

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Mar 20, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 20, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 20, 2019

@cmonr cmonr merged commit 2192a87 into ARMmbed:master Mar 20, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9146 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.