Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Increase receiving timeout for UDP echo non-blocking test #10184

Merged

Conversation

Projects
None yet
6 participants
@mirelachirica
Copy link
Contributor

commented Mar 21, 2019

Description

WISE-1570 is passing the UDPSOCKET_ECHOTEST_NONBLOCK only with a greater receiving timeout.

Note: UDPSOCKET_ECHOTEST_BURST_NONBLOCK on the other hand would pass even with a receiving timeout of 1 sec. I think the UDPSOCKET_ECHOTEST_NONBLOCK can be improved so that receiving timeout of 1 sec would be enough for this test too. I will create an issue about this to the test responsable team.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@0xc0170
Copy link
Member

left a comment

Change looks OK but commit does not contain details why this is being increased, add it from Description.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 22, 2019

@mirelachirica mirelachirica force-pushed the mirelachirica:wise_1570_udp_echotest_nonblocking branch from a05da1b to 6c44130 Mar 22, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Change looks OK but commit does not contain details why this is being increased, add it from Description.

Is the commit message ok, now?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@mirelachirica It would be good to know why the timeout needs to be increased, which is what I think @0xc0170 was asking for.

Mirela Chirica
Cellular: WISE-1570 needs greater receiving timeout to pass UDPSOCKET…
…_ECHOTEST_NONBLOCK test

Reason for needing greater timeout could be this test's performance.
UDPSOCKET_ECHOTEST_BURST_NONBLOCK is implementing the receiving
differently and is passing with 1 second timeout.

@mirelachirica mirelachirica force-pushed the mirelachirica:wise_1570_udp_echotest_nonblocking branch from 6c44130 to ec3c6f3 Mar 26, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Commit message updated.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

@cmonr cmonr requested a review from 0xc0170 Mar 26, 2019

@cmonr

cmonr approved these changes Mar 26, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10184 from mirelachirica/wise_1570_udp_ech…
…otest_nonblocking

Cellular: Increase receiving timeout for UDP echo non-blocking test
@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

Commit updated

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 26, 2019

@cmonr cmonr merged commit d26fe0f into ARMmbed:master Mar 27, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9895 cycles (-420 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.