Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanostack 802.15.4 RF drivers update #10185

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
8 participants
@artokin
Copy link
Contributor

commented Mar 21, 2019

Description

Sync Nanostack RF drivers from master copy:
-MCR20A: v1.0.5

A Fix to DEVICE_INTERRUPTIN flagging made in #10142

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso

@artokin artokin force-pushed the artokin:mcr20a_interruptin_flag_fix branch from df8b60f to e283db6 Mar 21, 2019

@ciarmcom ciarmcom requested review from JarkkoPaso and ARMmbed/mbed-os-maintainers Mar 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@artokin, thank you for your changes.
@JarkkoPaso @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

I'm starting to wonder whether the Driver header file should produce "#error Unsupported platform" or something similar. Now this flagging just leads to very weird build errors on platforms that cannot use the driver.

However, I'm not proposing changes to this PR. Just stating the fact that this if-deffing is not very elegant solution.

@jeromecoutant
Copy link
Contributor

left a comment

Link is failing...

Ex:
MCR20Drv.c is compiled and needs RF_IRQ_Disable() from a file that is not compiled any more...

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 22, 2019

Nanostack 802.15.4 RF drivers update
Sync Nanostack RF drivers from master copy:
-MCR20A: v1.0.6
-S2LP: v0.0.5

@artokin artokin force-pushed the artokin:mcr20a_interruptin_flag_fix branch from e283db6 to 0710298 Mar 22, 2019

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@jeromecoutant , MCR20Drv.c is now flagged, would you please try building again?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Mar 26, 2019

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 26, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10185 from artokin/mcr20a_interruptin_flag…
…_fix

Nanostack 802.15.4 RF drivers update

@cmonr cmonr merged commit d81f365 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10339 cycles (+70 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.